From d663cd1721822cd4253067d3944fe2c042700dff Mon Sep 17 00:00:00 2001 From: katelyn martin Date: Fri, 10 Jul 2026 00:00:00 +0000 Subject: [PATCH] chore(ci): remove failing coverage workflow MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit this commit removes the coverage.yml file from our ci workflows. see: https://github.com/linkerd/linkerd2-proxy/actions/metrics/performance this action is well-intentioned, but fails today nearly 40% of the time. as a result, we regularly see ❌'s in CI for pull requests and commits to main that are otherwise well-formed. moreover, the significant flakiness of this action means that we are not able to collect consistent metrics about our test coverage over time. it would be great to reintroduce this, but we should make this action work consistently before we reinstate it. Signed-off-by: katelyn martin --- .github/workflows/coverage.yml | 58 ---------------------------------- 1 file changed, 58 deletions(-) delete mode 100644 .github/workflows/coverage.yml diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml deleted file mode 100644 index 7d6186db59..0000000000 --- a/.github/workflows/coverage.yml +++ /dev/null @@ -1,58 +0,0 @@ -name: Coverage - -on: - push: - branches: [main] - pull_request: {} - -permissions: - contents: read - -concurrency: - group: ${{ github.workflow }}-${{ github.head_ref }} - cancel-in-progress: true - -env: - CARGO_INCREMENTAL: 0 - CARGO_NET_RETRY: 10 - RUSTFLAGS: "-D warnings -A deprecated --cfg tokio_unstable -C debuginfo=2" - RUSTUP_MAX_RETRIES: 10 - -jobs: - meta: - timeout-minutes: 5 - runs-on: ${{ vars.LINKERD2_PROXY_RUNNER || 'ubuntu-24.04' }} - steps: - - uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 - - id: changed - uses: tj-actions/changed-files@9426d40962ed5378910ee2e21d5f8c6fcbf2dd96 - with: - files: | - .codecov.yml - .github/workflows/coverage.yml - **/*.rs - files_ignore: | - *-proto/** - linkerd/transport-header/** - outputs: - any_changed: ${{ steps.changed.outputs.any_changed }} - - codecov: - needs: meta - if: (github.event_name == 'push' && github.ref == 'refs/heads/main') || needs.meta.outputs.any_changed == 'true' - runs-on: ${{ vars.LINKERD2_PROXY_RUNNER || 'ubuntu-24.04' }} - timeout-minutes: 30 - container: - image: docker://ghcr.io/linkerd/dev:v50-rust - options: --security-opt seccomp=unconfined # 🤷 - env: - CXX: "/usr/bin/clang++-19" - steps: - - uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 - - uses: Swatinem/rust-cache@c19371144df3bb44fab255c43d04cbc2ab54d1c4 - - run: cargo tarpaulin --locked --workspace --exclude=linkerd2-proxy --exclude=linkerd-transport-header --exclude=spire-proto --no-run - - run: cargo tarpaulin --locked --workspace --exclude=linkerd2-proxy --exclude=linkerd-transport-header --exclude=spire-proto --skip-clean --ignore-tests --no-fail-fast --out=Xml - # Some tests are especially flakey in coverage tests. That's fine. We - # only really care to measure how much of our codebase is covered. - continue-on-error: true - - uses: codecov/codecov-action@fb8b3582c8e4def4969c97caa2f19720cb33a72f