Refactor UrlOpener to singleton and simplify C API

Convert UrlOpener to a process-local singleton (UrlOpener::GetInstance()) and make IsSupported() a const instance method. Remove the opaque native_url_opener_t and the create/destroy C API functions; native_url_opener_is_supported() now takes no handle and native_url_opener_open(const char*) replaces the instance-based open call. Rename internal helper MakeResult -> MakeUrlOpenResult, update platform implementations to provide GetInstance(), and add deleted copy/move constructors and a private default ctor to UrlOpener. Update the C example to match the simplified API. These changes simplify lifetime management and usage of the URL opener across platforms.

Author: lijy91

examples/url_opener_c_example/main.c

@@ -5,22 +5,15 @@ int main(void) {
   printf("URL Opener C API Example\n");
   printf("========================\n\n");
 
-  native_url_opener_t opener = native_url_opener_create();
-  if (!opener) {
-    fprintf(stderr, "Failed to create URL opener instance.\n");
-    return 1;
-  }
-
-  if (!native_url_opener_is_supported(opener)) {
+  if (!native_url_opener_is_supported()) {
     printf("URL opening is not supported on this platform.\n");
-    native_url_opener_destroy(opener);
     return 0;
   }
 
   printf("URL opening is supported.\n");
   printf("Opening https://example.com ...\n");
 
-  native_url_open_result_t result = native_url_opener_open(opener, "https://example.com");
+  native_url_open_result_t result = native_url_opener_open("https://example.com");
   if (result.success) {
     printf("URL opened successfully.\n");
   } else {
@@ -30,6 +23,5 @@ int main(void) {
   }
 
   native_url_open_result_free(&result);
-  native_url_opener_destroy(opener);
   return result.success ? 0 : 1;
 }

src/capi/url_opener_c.cpp

@@ -10,10 +10,6 @@ using namespace nativeapi;
 
 namespace {
 
-UrlOpener* GetUrlOpener(native_url_opener_t opener) {
-  return static_cast<UrlOpener*>(opener);
-}
-
 native_url_open_error_code_t ToCErrorCode(UrlOpenErrorCode code) {
   switch (code) {
     case UrlOpenErrorCode::kNone:
@@ -33,9 +29,9 @@ native_url_open_error_code_t ToCErrorCode(UrlOpenErrorCode code) {
   }
 }
 
-native_url_open_result_t MakeResult(bool success,
-                                    native_url_open_error_code_t error_code,
-                                    const std::string& message) {
+native_url_open_result_t MakeUrlOpenResult(bool success,
+                                           native_url_open_error_code_t error_code,
+                                           const std::string& message) {
   native_url_open_result_t result = {};
   result.success = success;
   result.error_code = error_code;
@@ -45,47 +41,27 @@ native_url_open_result_t MakeResult(bool success,
 
 }  // namespace
 
-native_url_opener_t native_url_opener_create(void) {
-  try {
-    return static_cast<native_url_opener_t>(new UrlOpener());
-  } catch (...) {
-    return nullptr;
-  }
-}
-
-void native_url_opener_destroy(native_url_opener_t opener) {
-  delete GetUrlOpener(opener);
-}
-
-bool native_url_opener_is_supported(native_url_opener_t opener) {
-  if (!opener) {
-    return false;
-  }
-
+bool native_url_opener_is_supported(void) {
   try {
-    return UrlOpener::IsSupported();
+    return UrlOpener::GetInstance().IsSupported();
   } catch (...) {
     return false;
   }
 }
 
-native_url_open_result_t native_url_opener_open(native_url_opener_t opener, const char* url) {
-  if (!opener) {
-    return MakeResult(false, NATIVE_URL_OPEN_ERROR_INVOCATION_FAILED, "URL opener is null.");
-  }
-
+native_url_open_result_t native_url_opener_open(const char* url) {
   if (!url) {
-    return MakeResult(false, NATIVE_URL_OPEN_ERROR_INVALID_URL_EMPTY, "URL is empty.");
+    return MakeUrlOpenResult(false, NATIVE_URL_OPEN_ERROR_INVALID_URL_EMPTY, "URL is empty.");
   }
 
   try {
-    const UrlOpenResult result = GetUrlOpener(opener)->Open(std::string(url));
-    return MakeResult(result.success, ToCErrorCode(result.error_code), result.error_message);
+    const UrlOpenResult result = UrlOpener::GetInstance().Open(std::string(url));
+    return MakeUrlOpenResult(result.success, ToCErrorCode(result.error_code), result.error_message);
   } catch (const std::exception& e) {
-    return MakeResult(false, NATIVE_URL_OPEN_ERROR_INVOCATION_FAILED, e.what());
+    return MakeUrlOpenResult(false, NATIVE_URL_OPEN_ERROR_INVOCATION_FAILED, e.what());
   } catch (...) {
-    return MakeResult(false, NATIVE_URL_OPEN_ERROR_INVOCATION_FAILED,
-                      "Unexpected error while opening URL.");
+    return MakeUrlOpenResult(false, NATIVE_URL_OPEN_ERROR_INVOCATION_FAILED,
+                             "Unexpected error while opening URL.");
   }
 }
 

src/capi/url_opener_c.h

@@ -12,11 +12,6 @@
 extern "C" {
 #endif
 
-/**
- * @brief Opaque handle for a URL opener instance.
- */
-typedef void* native_url_opener_t;
-
 /**
  * @brief Error codes returned by URL opening APIs.
  */
@@ -38,31 +33,19 @@ typedef struct {
   char* error_message;
 } native_url_open_result_t;
 
-/**
- * @brief Create a URL opener instance.
- */
-FFI_PLUGIN_EXPORT
-native_url_opener_t native_url_opener_create(void);
-
-/**
- * @brief Destroy a URL opener instance.
- */
-FFI_PLUGIN_EXPORT
-void native_url_opener_destroy(native_url_opener_t opener);
-
 /**
  * @brief Check whether URL opening is supported on this platform.
  */
 FFI_PLUGIN_EXPORT
-bool native_url_opener_is_supported(native_url_opener_t opener);
+bool native_url_opener_is_supported(void);
 
 /**
  * @brief Attempt to open URL with the system default browser.
  *
  * Caller must release result.error_message via native_url_open_result_free().
  */
 FFI_PLUGIN_EXPORT
-native_url_open_result_t native_url_opener_open(native_url_opener_t opener, const char* url);
+native_url_open_result_t native_url_opener_open(const char* url);
 
 /**
  * @brief Free owned memory inside a native_url_open_result_t.

src/platform/android/url_opener_android.cpp

@@ -11,7 +11,12 @@ UrlLaunchOutcome LaunchUnsupported(const std::string& url) {
 
 }  // namespace
 
-bool UrlOpener::IsSupported() {
+UrlOpener& UrlOpener::GetInstance() {
+  static UrlOpener instance;
+  return instance;
+}
+
+bool UrlOpener::IsSupported() const {
   return false;
 }
 

src/platform/ios/url_opener_ios.mm

@@ -76,7 +76,12 @@ UrlLaunchOutcome LaunchUrl(const std::string& url) {
 
 }  // namespace
 
-bool UrlOpener::IsSupported() {
+UrlOpener& UrlOpener::GetInstance() {
+  static UrlOpener instance;
+  return instance;
+}
+
+bool UrlOpener::IsSupported() const {
   return true;
 }
 

src/platform/linux/url_opener_linux.cpp

@@ -24,7 +24,12 @@ UrlLaunchOutcome LaunchUrl(const std::string& url) {
 
 }  // namespace
 
-bool UrlOpener::IsSupported() {
+UrlOpener& UrlOpener::GetInstance() {
+  static UrlOpener instance;
+  return instance;
+}
+
+bool UrlOpener::IsSupported() const {
   return true;
 }
 

src/platform/macos/url_opener_macos.mm

@@ -29,7 +29,12 @@ UrlLaunchOutcome LaunchUrl(const std::string& url) {
 
 }  // namespace
 
-bool UrlOpener::IsSupported() {
+UrlOpener& UrlOpener::GetInstance() {
+  static UrlOpener instance;
+  return instance;
+}
+
+bool UrlOpener::IsSupported() const {
   return true;
 }
 

src/platform/ohos/url_opener_ohos.cpp

@@ -11,7 +11,12 @@ UrlLaunchOutcome LaunchUnsupported(const std::string& url) {
 
 }  // namespace
 
-bool UrlOpener::IsSupported() {
+UrlOpener& UrlOpener::GetInstance() {
+  static UrlOpener instance;
+  return instance;
+}
+
+bool UrlOpener::IsSupported() const {
   return false;
 }
 

src/platform/windows/url_opener_windows.cpp

@@ -23,7 +23,12 @@ UrlLaunchOutcome LaunchUrl(const std::string& url) {
 
 }  // namespace
 
-bool UrlOpener::IsSupported() {
+UrlOpener& UrlOpener::GetInstance() {
+  static UrlOpener instance;
+  return instance;
+}
+
+bool UrlOpener::IsSupported() const {
   return true;
 }
 

src/url_opener.h

@@ -21,9 +21,19 @@ struct UrlOpenResult {
 
 class UrlOpener {
  public:
-  static bool IsSupported();
+  static UrlOpener& GetInstance();
+
+  bool IsSupported() const;
 
   UrlOpenResult Open(const std::string& url) const;
+
+  UrlOpener(const UrlOpener&) = delete;
+  UrlOpener& operator=(const UrlOpener&) = delete;
+  UrlOpener(UrlOpener&&) = delete;
+  UrlOpener& operator=(UrlOpener&&) = delete;
+
+ private:
+  UrlOpener() = default;
 };
 
 }  // namespace nativeapi