From 48b3038ecd2819d3ad400afcd179028803f247e5 Mon Sep 17 00:00:00 2001 From: Khalil Estell Date: Sun, 23 Aug 2026 05:31:10 -0700 Subject: [PATCH] Drop stray override on non-virtual mock destructors hal::usb::control_endpoint and hal::usb::interface both have protected, non-virtual destructors by design. Surfaced by a clean conan create build after bumping libhal-util's version. --- v1/test_package/main.cpp | 4 ++-- v1/tests/test_util.cppm | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/v1/test_package/main.cpp b/v1/test_package/main.cpp index f50d38e..0ddce1f 100644 --- a/v1/test_package/main.cpp +++ b/v1/test_package/main.cpp @@ -32,7 +32,7 @@ void pump(async::future& p_future, hal::usize p_max_steps = 50) class stub_control_endpoint : public hal::usb::control_endpoint { public: - ~stub_control_endpoint() override = default; + ~stub_control_endpoint() = default; hal::usize m_connect_calls = 0; @@ -114,7 +114,7 @@ class stub_control_endpoint : public hal::usb::control_endpoint class stub_interface : public hal::usb::interface { public: - ~stub_interface() override = default; + ~stub_interface() = default; private: async::future driver_write_descriptors( diff --git a/v1/tests/test_util.cppm b/v1/tests/test_util.cppm index ed08687..05ef36d 100644 --- a/v1/tests/test_util.cppm +++ b/v1/tests/test_util.cppm @@ -51,7 +51,7 @@ void pump(async::future& p_future, hal::usize p_max_steps = 500) export class mock_control_endpoint : public hal::usb::control_endpoint { public: - ~mock_control_endpoint() override = default; + ~mock_control_endpoint() = default; void set_read_data(std::span p_data) { @@ -225,7 +225,7 @@ private: export class mock_interface : public hal::usb::interface { public: - ~mock_interface() override = default; + ~mock_interface() = default; bool m_handle_request_result = false; bool m_write_string_result = false;