From e04269323b7eb6a55d65b6549b757c8830b97491 Mon Sep 17 00:00:00 2001 From: Arseniy Obolenskiy Date: Wed, 14 May 2025 22:49:08 +0200 Subject: [PATCH] Remove misc-include-cleaner suppression in util_tests.cpp --- .clang-tidy | 2 +- modules/core/util/func_tests/util_tests.cpp | 9 ++++----- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index 6a0bbde4b..4ce856a75 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -86,4 +86,4 @@ CheckOptions: - key: readability-identifier-length.MinimumParameterNameLength value: 1 - key: misc-include-cleaner.IgnoreHeaders - value: '(__chrono/.*)' + value: '(__chrono/.*|stdlib\.h)' diff --git a/modules/core/util/func_tests/util_tests.cpp b/modules/core/util/func_tests/util_tests.cpp index 9467d746d..2b7ca7970 100644 --- a/modules/core/util/func_tests/util_tests.cpp +++ b/modules/core/util/func_tests/util_tests.cpp @@ -10,11 +10,11 @@ TEST(util_tests, check_unset_env) { #ifndef _WIN32 int save_var = ppc::util::GetPPCNumThreads(); - unsetenv("PPC_NUM_THREADS"); // NOLINT(concurrency-mt-unsafe,misc-include-cleaner) + unsetenv("PPC_NUM_THREADS"); // NOLINT(concurrency-mt-unsafe) EXPECT_EQ(ppc::util::GetPPCNumThreads(), 1); - setenv("PPC_NUM_THREADS", std::to_string(save_var).c_str(), 1); // NOLINT(concurrency-mt-unsafe,misc-include-cleaner) + setenv("PPC_NUM_THREADS", std::to_string(save_var).c_str(), 1); // NOLINT(concurrency-mt-unsafe) #else GTEST_SKIP(); #endif @@ -25,12 +25,11 @@ TEST(util_tests, check_set_env) { int save_var = ppc::util::GetPPCNumThreads(); const int num_threads = static_cast(std::thread::hardware_concurrency()); - // NOLINTNEXTLINE(concurrency-mt-unsafe,misc-include-cleaner) - setenv("PPC_NUM_THREADS", std::to_string(num_threads).c_str(), 1); + setenv("PPC_NUM_THREADS", std::to_string(num_threads).c_str(), 1); // NOLINT(concurrency-mt-unsafe) EXPECT_EQ(ppc::util::GetPPCNumThreads(), num_threads); - setenv("PPC_NUM_THREADS", std::to_string(save_var).c_str(), 1); // NOLINT(concurrency-mt-unsafe,misc-include-cleaner) + setenv("PPC_NUM_THREADS", std::to_string(save_var).c_str(), 1); // NOLINT(concurrency-mt-unsafe) #else GTEST_SKIP(); #endif