refactor Task module: replace kTypeOfTaskStrings with inline TypeOfTaskToString function, improve error handling for unknown task type

Author: allnes

modules/core/task/include/task.hpp

@@ -39,16 +39,16 @@ enum TypeOfTask : uint8_t {
   kUnknown
 };
 
-constexpr std::pair<TypeOfTask, std::string_view> kTypeOfTaskStrings[] = {
-    {TypeOfTask::kALL, "all"},
-    {TypeOfTask::kMPI, "mpi"},
-    {TypeOfTask::kOMP, "omp"},
-    {TypeOfTask::kSEQ, "seq"},
-    {TypeOfTask::kSTL, "stl"},
-    {TypeOfTask::kTBB, "tbb"},
-};
+inline std::string TypeOfTaskToString(TypeOfTask type) {
+  constexpr std::pair<TypeOfTask, std::string> kTypeOfTaskStrings[] = {
+      {TypeOfTask::kALL, "all"},
+      {TypeOfTask::kMPI, "mpi"},
+      {TypeOfTask::kOMP, "omp"},
+      {TypeOfTask::kSEQ, "seq"},
+      {TypeOfTask::kSTL, "stl"},
+      {TypeOfTask::kTBB, "tbb"},
+  };
 
-inline std::string_view TypeOfTaskToString(TypeOfTask type) {
   for (const auto& [key, value] : kTypeOfTaskStrings) {
     if (key == type) return value;
   }
@@ -89,9 +89,9 @@ inline std::string GetStringTaskType(TypeOfTask type_of_task, const std::string&
   auto list_settings = ppc::util::InitJSONPtr();
   file >> *list_settings;
 
-  std::string type_str = std::string(TypeOfTaskToString(type_of_task));
+  std::string type_str = TypeOfTaskToString(type_of_task);
   if (type_str == "unknown") {
-    return "unknown";
+    throw std::runtime_error("Unknown task type");
   }
 
   return type_str + "_" + std::string((*list_settings)["tasks"][type_str]);