Merge branch 'master' into valgrind-all

Author: allnes

.clang-tidy

@@ -24,12 +24,12 @@ Checks: >
   -misc-const-correctness,
   -misc-non-private-member-variables-in-classes,
   -modernize-avoid-c-arrays,
-  -modernize-loop-convert,
   -modernize-use-trailing-return-type,
   -portability-template-virtual-member-function,
   -readability-magic-numbers
 
 WarningsAsErrors: "*"
+HeaderFilterRegex: '.*/(modules|tasks)/.*'
 
 CheckOptions:
   - key:             readability-identifier-naming.ClassCase

.editorconfig

@@ -0,0 +1,27 @@
+root = true
+
+[*]
+charset = utf-8
+end_of_line = lf
+insert_final_newline = true
+trim_trailing_whitespace = true
+indent_style = space
+indent_size = 4
+
+[*.{cpp,h,hpp,c}]
+indent_size = 2
+
+[*.{yml,yaml}]
+indent_size = 2
+
+[*.py]
+indent_size = 4
+
+[Makefile]
+indent_style = tab
+
+[{CMakeLists.txt,*.cmake}]
+indent_size = 2
+
+[*.{md,rst}]
+trim_trailing_whitespace = false

.github/labeler.yml

@@ -1,15 +1,17 @@
 'task:all':
-  - "tasks/all/**"
+  - "tasks/**/all"
 'task:mpi':
-  - "tasks/mpi/**"
+  - "tasks/**/mpi"
 'task:omp':
-  - "tasks/omp/**"
+  - "tasks/**/omp"
 'task:seq':
-  - "tasks/seq/**"
+  - "tasks/**/seq"
 'task:stl':
-  - "tasks/stl/**"
+  - "tasks/**/stl"
 'task:tbb':
-  - "tasks/tbb/**"
+  - "tasks/**/tbb"
+task:
+  - "tasks/**"
 ci:
   - ".github/**"
   - "appveyor.yml"

.github/workflows/docker.yml

@@ -0,0 +1,46 @@
+on:
+  push:
+    branches:
+      - master
+    paths:
+      - 'docker/**'
+  pull_request_target:
+    paths:
+      - 'docker/**'
+
+permissions:
+  contents: read
+  packages: write
+
+jobs:
+  build-and-push:
+    name: Build & Push Docker Image
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Check out code
+        uses: actions/checkout@v3
+
+      - name: Set up QEMU
+        uses: docker/setup-qemu-action@v2
+        with:
+          platforms: linux/amd64,linux/arm64
+
+      - name: Set up Docker Buildx
+        uses: docker/setup-buildx-action@v2
+
+      - name: Log in to GHCR
+        uses: docker/login-action@v2
+        with:
+          registry: ghcr.io
+          username: ${{ github.actor }}
+          password: ${{ secrets.DOCKER_TOKEN }}
+
+      - name: Build and push multi-arch image
+        uses: docker/build-push-action@v4
+        with:
+          context: .
+          file: ./docker/ubuntu.Dockerfile
+          platforms: linux/amd64,linux/arm64
+          push: true  # ${{ github.ref == 'refs/heads/master' }}
+          tags: ghcr.io/learning-process/ppc-ubuntu:latest

.github/workflows/mac.yml

@@ -2,7 +2,7 @@ on:
   workflow_call:
 
 jobs:
-  macos-clang-build:
+  clang-build:
     runs-on: macOS-latest
     strategy:
       matrix:
@@ -17,12 +17,9 @@ jobs:
           xcode-version: 'latest-stable'
       - name: Setup environment
         run: |
-          brew update-reset
-          brew install ninja mpich llvm
-          brew install libomp
+          brew update
+          brew install ninja mpich llvm libomp openssl
           brew link libomp --overwrite --force
-          brew install openssl
-          brew link openssl --overwrite --force
       - name: ccache
         uses: hendrikmuhs/ccache-action@v1.2
         with:
@@ -47,9 +44,9 @@ jobs:
         with:
           path: install
           name: ${{ matrix.build_type == 'Debug' && 'macos-clang-debug-install' || 'macos-clang-install' }}
-  macos-clang-test:
+  clang-test:
     needs:
-      - macos-clang-build
+      - clang-build
     runs-on: macOS-latest
     steps:
       - uses: actions/checkout@v4
@@ -59,12 +56,9 @@ jobs:
           xcode-version: 'latest-stable'
       - name: Setup environment
         run: |
-          brew update-reset
-          brew install ninja mpich llvm
-          brew install libomp
+          brew update
+          brew install ninja mpich llvm libomp openssl
           brew link libomp --overwrite --force
-          brew install openssl
-          brew link openssl --overwrite --force
       - name: Download installed package
         uses: actions/download-artifact@v4
         with:
@@ -81,9 +75,9 @@ jobs:
         run: python3 scripts/run_tests.py --running-type="threads" --counts 1 2 3 4
         env:
           PPC_NUM_PROC: 1
-  macos-clang-test-extended:
+  clang-test-extended:
     needs:
-      - macos-clang-test
+      - clang-test
     runs-on: macOS-latest
     steps:
       - uses: actions/checkout@v4
@@ -93,12 +87,9 @@ jobs:
           xcode-version: 'latest-stable'
       - name: Setup environment
         run: |
-          brew update-reset
-          brew install ninja mpich llvm
-          brew install libomp
+          brew update
+          brew install ninja mpich llvm libomp openssl
           brew link libomp --overwrite --force
-          brew install openssl
-          brew link openssl --overwrite --force
       - name: Download installed package
         uses: actions/download-artifact@v4
         with:

.github/workflows/main.yml

@@ -36,3 +36,8 @@ jobs:
       - mac
       - windows
     uses: ./.github/workflows/perf.yml
+
+  pages:
+    needs:
+      - perf
+    uses: ./.github/workflows/pages.yml

.github/workflows/pages.yml

@@ -1,8 +1,7 @@
 name: Pages
 
 on:
-  push:
-  pull_request:
+  workflow_call:
   workflow_dispatch:
 
 permissions:
@@ -110,6 +109,11 @@ jobs:
         with:
           name: scoreboard
           path: ./scoreboard/
+      - name: Download coverage artifact
+        uses: actions/download-artifact@v4
+        with:
+          name: cov-report
+          path: ./coverage/
       - name: Upload artifact
         uses: actions/upload-pages-artifact@v3
         with:

.github/workflows/pre-commit.yml

@@ -0,0 +1,23 @@
+name: Pre-commit checks
+
+on:
+  pull_request:
+
+jobs:
+  pre-commit:
+    runs-on: ubuntu-24.04
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          submodules: recursive
+          fetch-depth: 0
+      - name: Setup environment
+        run: |
+          sudo apt-get update
+          sudo apt-get install --no-install-recommends -y \
+            gcc-14 g++-14 ninja-build python3-pip clang-format-16
+          python3 -m pip install -r requirements.txt
+      - name: Run pre-commit checks
+        run: |
+          git fetch origin ${{ github.base_ref }}:${{ github.base_ref }}
+          pre-commit run --from-ref ${{ github.base_ref }} --to-ref HEAD

.github/workflows/ubuntu.yml

@@ -2,7 +2,7 @@ on:
   workflow_call:
 
 jobs:
-  ubuntu-gcc-build:
+  gcc-build:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
@@ -53,9 +53,9 @@ jobs:
           name: ${{ matrix.build_type == 'Debug' &&
             format('ubuntu-gcc-debug-install-{0}', matrix.os) ||
             format('ubuntu-gcc-install-{0}', matrix.os) }}
-  ubuntu-gcc-test:
+  gcc-test:
     needs:
-      - ubuntu-gcc-build
+      - gcc-build
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
@@ -83,9 +83,9 @@ jobs:
         run: python3 scripts/run_tests.py --running-type="threads" --counts 1 2 3 4
         env:
           PPC_NUM_PROC: 1
-  ubuntu-gcc-test-extended:
+  gcc-test-extended:
     needs:
-      - ubuntu-gcc-test
+      - gcc-test
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
@@ -109,7 +109,7 @@ jobs:
         run: python3 scripts/run_tests.py --running-type="threads" --counts 5 7 11 13
         env:
           PPC_NUM_PROC: 1
-  ubuntu-clang-build:
+  clang-build:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
@@ -153,9 +153,9 @@ jobs:
         with:
           path: install
           name: ubuntu-clang-install-${{ matrix.os }}
-  ubuntu-clang-test:
+  clang-test:
     needs:
-      - ubuntu-clang-build
+      - clang-build
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
@@ -185,9 +185,9 @@ jobs:
         run: python3 scripts/run_tests.py --running-type="threads" --counts 1 2 3 4
         env:
           PPC_NUM_PROC: 1
-  ubuntu-clang-test-extended:
+  clang-test-extended:
     needs:
-      - ubuntu-clang-test
+      - clang-test
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
@@ -213,9 +213,9 @@ jobs:
         run: python3 scripts/run_tests.py --running-type="threads" --counts 5 7 11 13
         env:
           PPC_NUM_PROC: 1
-  ubuntu-clang-sanitizer-build:
+  clang-sanitizer-build:
     needs:
-      - ubuntu-clang-build
+      - clang-build
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
@@ -242,7 +242,7 @@ jobs:
         run: >
           cmake -S . -B build -G Ninja
           -D CMAKE_C_COMPILER_LAUNCHER=ccache -D CMAKE_CXX_COMPILER_LAUNCHER=ccache
-          -D CMAKE_BUILD_TYPE=RELEASE
+          -D CMAKE_BUILD_TYPE=RelWithDebInfo
           -D ENABLE_ADDRESS_SANITIZER=ON -D ENABLE_UB_SANITIZER=ON -D ENABLE_LEAK_SANITIZER=ON
           -D CMAKE_INSTALL_PREFIX=install
         env:
@@ -262,9 +262,9 @@ jobs:
         with:
           path: install
           name: ubuntu-clang-sanitizer-install-${{ matrix.os }}
-  ubuntu-clang-sanitizer-test:
+  clang-sanitizer-test:
     needs:
-      - ubuntu-clang-sanitizer-build
+      - clang-sanitizer-build
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
@@ -301,9 +301,9 @@ jobs:
           PPC_ASAN_RUN: 1
           ASAN_OPTIONS: abort_on_error=1
           UBSAN_OPTIONS: halt_on_error=1
-  ubuntu-clang-sanitizer-test-extended:
+  clang-sanitizer-test-extended:
     needs:
-      - ubuntu-clang-sanitizer-test
+      - clang-sanitizer-test
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
@@ -331,10 +331,10 @@ jobs:
         env:
           PPC_NUM_PROC: 1
           PPC_ASAN_RUN: 1
-  ubuntu-gcc-build-codecov:
+  gcc-build-codecov:
     needs:
-      - ubuntu-gcc-test-extended
-      - ubuntu-clang-test-extended
+      - gcc-test-extended
+      - clang-test-extended
     runs-on: ubuntu-24.04
     steps:
       - uses: actions/checkout@v4
@@ -390,7 +390,18 @@ jobs:
         with:
           files: coverage.xml
       - name: Upload coverage report artifact
+        id: upload-cov
         uses: actions/upload-artifact@v4
         with:
           name: cov-report
           path: 'cov-report'
+      - name: Comment coverage report link
+        # TODO: Support PRs from forks too
+        if: ${{ github.event_name == 'pull_request' && !github.event.pull_request.head.repo.fork }}
+        uses: peter-evans/create-or-update-comment@v4
+        with:
+          token: ${{ secrets.GITHUB_TOKEN }}
+          issue-number: ${{ github.event.pull_request.number }}
+          body: |
+            Coverage report is available for download
+            [here](https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }})