simplify ppc::util::FuncName() implementation and refine documentation

Author: allnes

modules/core/util/include/util.hpp

@@ -27,43 +27,30 @@ using NlohmannJsonTypeError = nlohmann::json::type_error;
 namespace ppc::util {
 
 /**
- * @brief Extract the bare function name (e.g. "PreProcessing" or "foo")
- *        from a full signature provided by std::source_location,
- *        working both on GCC/Clang and MSVC.
+ * @brief Obtain the simple function name (e.g. "PreProcessing" or "foo")
+ *        from the full signature returned by std::source_location.
  *
- * @param loc  Source location (file, line, pretty-signature).
+ * @param loc  Source location info (file, line, full signature).
  *             Defaults to the call site via std::source_location::current().
- * @return A std::string containing only the function name.
+ * @return A std::string with only the function’s unqualified name.
  *
- * @note  On GCC/Clang, loc.function_name() yields a “pretty” signature
- *        including namespaces, templates and parameter list.
- *        On MSVC, it also includes return type and calling convention.
- *        This function strips off everything before the last `::` (if any),
- *        and any parameter list or qualifiers after the name.
+ * @details
+ * - On GCC/Clang, function_name() returns a pretty signature
+ *   including namespaces, templates, and parameters.
+ * - On MSVC, it also includes return type and calling convention.
+ * - This routine removes any leading scope qualifiers (“::…”) and
+ *   drops everything from the first '(' onward.
  */
-inline std::string FuncName(const std::source_location& loc = std::source_location::current()) {
-  std::string_view full = loc.function_name();
-  // 1) find end of name (just before '(' or end of string)
-  size_t paren = full.find('(');
-  size_t name_end = (paren == std::string_view::npos ? full.size() : paren);
-
-  // 2) try to strip namespaces/classes via '::'
-  size_t colons = full.rfind("::", name_end);
-  size_t start = (colons == std::string_view::npos ? 0 : colons + 2);
 
-  // 3) on MSVC there's often a return-type + "__cdecl " prefix before the name
-#ifdef _MSC_VER
-  if (colons == std::string_view::npos) {
-    // if no '::', drop everything up to last space before name_end
-    size_t last_space = full.rfind(' ', name_end);
-    if (last_space != std::string_view::npos) {
-      start = last_space + 1;
-    }
+inline std::string FuncName(const std::source_location& loc = std::source_location::current()) {
+  std::string s{loc.function_name()};
+  if (auto p = s.find('('); p != std::string::npos) {
+    s.resize(p);  // drop “(…)”
   }
-#endif
-
-  // 4) construct owning string of just the name
-  return std::string{full.substr(start, name_end - start)};
+  if (auto p = s.rfind("::"); p != std::string::npos) {
+    s.erase(0, p + 2);  // drop namespaces
+  }
+  return s;
 }
 
 enum GTestParamIndex : uint8_t { kTaskGetter, kNameTest, kTestParams };