fix(networking): explicit sync for gossipsub outbound stream setup#765
Merged
tcoratger merged 1 commit intoMay 23, 2026
Conversation
…eer lock Two code paths concurrently attempted to open the outbound gossipsub stream for the same peer: the dialing path called the setup helper directly after status exchange, and the inbound-stream handler called it once the peer's reciprocal stream arrived. Both could pass the has-outbound-stream check before either registered, leaving an orphaned QUIC stream behind. A 100ms sleep masked the race by giving the direct path enough time to win. Serialise the check-and-open under a per-peer asyncio.Lock so only one stream is opened. The deferred-setup helper is no longer needed and the inbound handler now calls the idempotent setup directly. Lock entries are cleared on disconnect to bound memory. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
await asyncio.sleep(0.1)in the deferred-setup helper — timing-dependent papering over a TOCTOU race.asyncio.Lockthat makes check-and-open atomic. The deferred-setup helper is deleted; the inbound handler now calls the idempotent setup directly. Lock entries are cleared on disconnect to bound memory.Why the delay was unnecessary
The two comments around the removed delay claimed it "lets the dialer complete its status exchange first" and "prevents deadlock". Neither is true:
The delay was, in practice, only serialising against the local TOCTOU race on the dialer side — which the lock now handles deterministically.
Test plan
uv run pytest tests/lean_spec/subspecs/networking/— 804 passedjust check— ruff check, ruff format, ty check, codespell, mdformat all pass🤖 Generated with Claude Code