Commit f40c86e
ci: use shared gh-actions/actions/contract-tests action (#164)
**Requirements**
- [x] I have added test coverage for new or changed functionality
- [x] I have followed the repository's [pull request submission
guidelines](../blob/main/CONTRIBUTING.md#submitting-pull-requests)
- [x] I have validated my changes against all supported platform
versions
**Related issues**
N/A — CI-only change.
**Describe the solution you've provided**
Replace the local `.github/actions/contract-tests` action with the
shared
`launchdarkly/gh-actions/actions/contract-tests@contract-tests-v1`
action.
The local action accepted a `token` input but never forwarded it, so
`GITHUB_TOKEN` was not used when downloading the contract test harness
(leading to potential rate limiting). The shared action properly passes
the token both as an `Authorization` header on the curl request and as
the `GITHUB_TOKEN` env var for the downloader script.
Since the shared action only handles downloading and running the harness
(not building/starting the test service), the build and start steps are
now explicit workflow steps.
**Describe alternatives you've considered**
Could have fixed the local action to forward the token to the Makefile,
but using the shared action is more maintainable and consistent with
other SDK repos.
**Additional context**
Both `java-server-sdk.yml` and `nightly-contract-tests.yml` are updated.
The Makefile is left unchanged so local development workflows still
work."
Link to Devin session:
https://app.devin.ai/sessions/02984ba491764e598f041b70041206ba
Requested by: @kinyoklion
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Low Risk**
> CI-only workflow changes; no application runtime or SDK library
behavior is modified.
>
> **Overview**
> Removes the repo-local **contract-tests** composite action and wires
**java-server-sdk** and **nightly-contract-tests** workflows to
**`launchdarkly/gh-actions/actions/contract-tests@contract-tests-v1`**.
>
> Contract testing now **explicitly** runs `make build-contract-tests`
and `make start-contract-test-service-bg` before the harness. **v2** and
**v3** harness runs are separate steps (v3 pinned to `v3.0.0-alpha.6`),
each passing **`GITHUB_TOKEN`**, suppression files via
**`extra_params`**, and shared options like **`enable_persistence_tests:
'false'`**. Nightly v3 still passes **`-enable-long-running-tests`**
through **`extra_params`**.
>
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
3580edb. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>1 parent 28962e5 commit f40c86e
3 files changed
Lines changed: 52 additions & 32 deletions
File tree
- .github
- actions/contract-tests
- workflows
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
40 | | - | |
41 | | - | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
42 | 50 | | |
43 | | - | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
44 | 64 | | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
45 | 68 | | |
46 | 69 | | |
47 | 70 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
33 | | - | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
34 | 42 | | |
35 | | - | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
36 | 56 | | |
37 | | - | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
38 | 60 | | |
39 | 61 | | |
40 | 62 | | |
| |||
0 commit comments