Skip to content

Commit 2dd879f

Browse files
committed
More test fixes
1 parent 21c75ba commit 2dd879f

6 files changed

Lines changed: 48 additions & 16 deletions

File tree

sqlx-cli/src/database.rs

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,17 @@ pub async fn setup(
6262
connect_opts: &ConnectOpts,
6363
) -> anyhow::Result<()> {
6464
create(connect_opts).await?;
65-
migrate::run(config, migration_source, connect_opts, false, false, None).await
65+
migrate::run(
66+
config,
67+
migration_source,
68+
connect_opts,
69+
false,
70+
false,
71+
None,
72+
false,
73+
Vec::new(),
74+
)
75+
.await
6676
}
6777

6878
async fn ask_to_continue_drop(db_url: String) -> bool {

sqlx-cli/src/migrate.rs

Lines changed: 20 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -293,10 +293,17 @@ pub async fn run(
293293
let elapsed = if dry_run || skip {
294294
Duration::new(0, 0)
295295
} else if params_from_env {
296-
conn.apply(&migration.process_parameters(&env_params)?)
297-
.await?
296+
conn.apply(
297+
config.migrate.table_name(),
298+
&migration.process_parameters(&env_params)?,
299+
)
300+
.await?
298301
} else if !params.is_empty() {
299-
conn.apply(&migration.process_parameters(&params)?).await?
302+
conn.apply(
303+
config.migrate.table_name(),
304+
&migration.process_parameters(&params)?,
305+
)
306+
.await?
300307
} else {
301308
conn.apply(config.migrate.table_name(), migration).await?
302309
};
@@ -408,10 +415,17 @@ pub async fn revert(
408415
let elapsed = if dry_run || skip {
409416
Duration::new(0, 0)
410417
} else if params_from_env {
411-
conn.revert(&migration.process_parameters(&env_params)?)
412-
.await?
418+
conn.revert(
419+
config.migrate.table_name(),
420+
&migration.process_parameters(&env_params)?,
421+
)
422+
.await?
413423
} else if !params.is_empty() {
414-
conn.revert(&migration.process_parameters(&params)?).await?
424+
conn.revert(
425+
config.migrate.table_name(),
426+
&migration.process_parameters(&params)?,
427+
)
428+
.await?
415429
} else {
416430
conn.revert(config.migrate.table_name(), migration).await?
417431
};

sqlx-cli/src/opt.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ use crate::config::migrate::{DefaultMigrationType, DefaultVersioning};
22
use crate::config::Config;
33
use anyhow::Context;
44
use chrono::Utc;
5-
use std::error::Error;
65
use clap::{
76
builder::{styling::AnsiColor, Styles},
87
Args, Parser,
@@ -11,6 +10,7 @@ use clap::{
1110
use clap_complete::Shell;
1211
use sqlx::migrate::{MigrateError, Migrator, ResolveWith};
1312
use std::env;
13+
use std::error::Error;
1414
use std::ops::{Deref, Not};
1515
use std::path::PathBuf;
1616

sqlx-core/src/migrate/migration.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ use sha2::{Digest, Sha384};
22
use std::borrow::Cow;
33
use std::collections::HashMap;
44

5-
use crate::sql_str::{SqlStr, SqlSafeStr};
5+
use crate::sql_str::{SqlSafeStr, SqlStr};
66

77
use super::{MigrateError, MigrationType};
88

sqlx-core/src/migrate/migrator.rs

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -259,10 +259,14 @@ impl Migrator {
259259
}
260260
None => {
261261
if self.template_parameters_from_env {
262-
conn.apply(&self.table_name, &migration.process_parameters(env_params.as_ref().unwrap())?)
263-
.await?;
262+
conn.apply(
263+
&self.table_name,
264+
&migration.process_parameters(env_params.as_ref().unwrap())?,
265+
)
266+
.await?;
264267
} else if let Some(params) = self.template_params.as_ref() {
265-
conn.apply(&self.table_name, &migration.process_parameters(params)?).await?;
268+
conn.apply(&self.table_name, &migration.process_parameters(params)?)
269+
.await?;
266270
} else {
267271
conn.apply(&self.table_name, migration).await?;
268272
}
@@ -339,10 +343,14 @@ impl Migrator {
339343
.filter(|m| m.version > target)
340344
{
341345
if self.template_parameters_from_env {
342-
conn.revert(&self.table_name, &migration.process_parameters(env_params.as_ref().unwrap())?)
343-
.await?;
346+
conn.revert(
347+
&self.table_name,
348+
&migration.process_parameters(env_params.as_ref().unwrap())?,
349+
)
350+
.await?;
344351
} else if let Some(params) = self.template_params.as_ref() {
345-
conn.revert(&self.table_name, &migration.process_parameters(params)?).await?;
352+
conn.revert(&self.table_name, &migration.process_parameters(params)?)
353+
.await?;
346354
} else {
347355
conn.revert(&self.table_name, migration).await?;
348356
}

sqlx-macros/src/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,9 +66,9 @@ pub fn derive_from_row(input: TokenStream) -> TokenStream {
6666
#[cfg(feature = "migrate")]
6767
#[proc_macro]
6868
pub fn migrate(input: TokenStream) -> TokenStream {
69+
use quote::quote;
6970
use std::collections::HashMap;
7071
use syn::{parse_macro_input, Expr, ExprArray, ExprLit, ExprPath, ExprTuple, Lit, LitStr};
71-
use quote::quote;
7272

7373
// Extract directory path, handling both direct literals and grouped literals
7474
fn extract_dir(expr: Option<Expr>) -> LitStr {

0 commit comments

Comments
 (0)