From 2ec6861c7185c6d9c0a613fc356167b37ed805c3 Mon Sep 17 00:00:00 2001 From: Imani Manyara Date: Mon, 28 Sep 2026 10:32:53 -0400 Subject: [PATCH 1/2] Run CI on every pull request so it can be a required check --- .github/workflows/phpstan.yml | 7 ++----- .github/workflows/rector.yml | 6 ++---- .github/workflows/run-tests.yml | 8 ++------ 3 files changed, 6 insertions(+), 15 deletions(-) diff --git a/.github/workflows/phpstan.yml b/.github/workflows/phpstan.yml index fefec7e..6b1a101 100644 --- a/.github/workflows/phpstan.yml +++ b/.github/workflows/phpstan.yml @@ -5,11 +5,8 @@ permissions: on: pull_request: - paths: - - '**.php' - - 'phpstan.neon.dist' - - 'phpstan-baseline.neon' - - '.github/workflows/phpstan.yml' + # No path filter: this workflow gates merges as a required status check, and a + # required check that never reports (a docs-only pull request) blocks it for good. concurrency: group: ${{ github.workflow }}-${{ github.ref }} diff --git a/.github/workflows/rector.yml b/.github/workflows/rector.yml index 25fa606..bb5a472 100644 --- a/.github/workflows/rector.yml +++ b/.github/workflows/rector.yml @@ -2,10 +2,8 @@ name: Rector on: pull_request: - paths: - - '**.php' - - 'rector.php' - - '.github/workflows/rector.yml' + # No path filter: this workflow gates merges as a required status check, and a + # required check that never reports (a docs-only pull request) blocks it for good. concurrency: group: ${{ github.workflow }}-${{ github.ref }} diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 411d829..ffd17f6 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -5,12 +5,8 @@ permissions: on: pull_request: - paths: - - '**.php' - - '.github/workflows/run-tests.yml' - - 'phpunit.xml.dist' - - 'composer.json' - - 'composer.lock' + # No path filter: this workflow gates merges as a required status check, and a + # required check that never reports (a docs-only pull request) blocks it for good. concurrency: group: ${{ github.workflow }}-${{ github.ref }} From 05e3a011be9a506e0d929549f75e16953d03e224 Mon Sep 17 00:00:00 2001 From: Imani Manyara Date: Mon, 28 Sep 2026 11:16:16 -0400 Subject: [PATCH 2/2] Replace a spread-then-override that PHPStan reads as a duplicate key --- tests/SlowPathBenchTest.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/SlowPathBenchTest.php b/tests/SlowPathBenchTest.php index dec470e..c603f97 100644 --- a/tests/SlowPathBenchTest.php +++ b/tests/SlowPathBenchTest.php @@ -68,7 +68,7 @@ 'name' => FluentRule::string()->required()->min(2)->max(255), 'email' => FluentRule::date()->required()->after('2024-01-01'), ]), - ])->validate(['users' => array_map(fn (array $u): array => [...$u, 'email' => '2025-06-15'], $users500)])], + ])->validate(['users' => array_map(fn (array $u): array => array_replace($u, ['email' => '2025-06-15']), $users500)])], ['string+boolean', 'per-item', fn () => RuleSet::from([ 'users' => FluentRule::array()->required()->each([