From 4c15eb918cb262314ee1292ec76e31a0a4f6c40c Mon Sep 17 00:00:00 2001 From: Imani Manyara Date: Wed, 16 Sep 2026 08:30:04 -0400 Subject: [PATCH] Call the shared tests workflow instead of restating it laranail/.github has shipped a reusable tests workflow for months and one package of fifty-one called it. That is why a single defect -- pinning the Laravel version into composer.json before the suite ran -- had to be fixed in twenty-two places, and why prefer-lowest had to be added in twenty-seven. Everything this file used to spell out now lives in one definition: the PHP matrix, the composer cache and the laranail archive eviction it needs, the prefer-lowest leg, fail-fast, the timeout. What stays here is what is genuinely this package's own -- its PHP versions, its extensions, its test command -- passed as inputs. REQUIRES the corrected laranail/.github tests.yml. The version dated 2026-08-28 defaults laravel-versions to ["13.*"] and runs `composer require illuminate/contracts` before the suite, which is the pin this change exists to remove, and it has no laranail cache eviction, so adopting it unfixed would serve stale archives from the moving v0.1.0 tag. Land that first. Resolve dependencies from the manifest, and cache them CI pinned versions into composer.json before running the suite. `composer require --no-update` EDITS the file -- verified: `^13.0` becomes `13.*` -- so every run tested a manifest the package does not ship. Nothing broke, because the forced constraint happened to agree with the declared one; it would have broken silently the first time either changed, and widening a package to `^13.0 || ^14.0` would never have been tested at all. The matrix keys feeding those pins are gone with them. Several were already inert: `testbench` and `carbon` were declared in the matrix and referenced by no step, so they pinned nothing and always resolved from composer.json. Also here, all measured rather than assumed: - A composer cache. Most workflows re-downloaded every dependency on every run, which is the largest avoidable draw on the Actions budget. - The cache drops laranail/* archives before installing. Those resolve through a single MOVING v0.1.0 tag, so composer's dist cache is keyed on a name whose contents change underneath it -- without the eviction a restored archive is silently stale, which is the failure this org has already hit once. - fail-fast off where it was on. "8.5 fails too" and "only 8.5 fails" are different bugs, and fail-fast hides which one a run found. - No coverage driver where nothing consumed the report. pcov instruments every file on every run; generating a report nobody reads is time billed for nothing. Untouched wherever an upload or a --min gate uses it. - paths-ignore '*.md' -> '**.md'. The root-only glob never matched docs/**, so documentation-only changes ran the full suite.