use CMake's join function for string concatenation, copy catalog version string using strncopy instead of using pointer

Author: var77

CMakeLists.txt

@@ -285,12 +285,8 @@ foreach(file ${_update_files})
 endforeach()
 
 # Convert the list to a C array
-set(COMPATIBLE_VERSIONS_ARRAY "")
-foreach(version ${COMPATIBLE_VERSIONS_LIST})
-  set(COMPATIBLE_VERSIONS_ARRAY "${COMPATIBLE_VERSIONS_ARRAY}\"${version}\", ")
-endforeach()
-string(REGEX REPLACE ", $|,$" "" COMPATIBLE_VERSIONS_ARRAY "${COMPATIBLE_VERSIONS_ARRAY}")
-set(COMPATIBLE_VERSIONS_ARRAY "{ ${COMPATIBLE_VERSIONS_ARRAY} }")
+string(JOIN "\",\"" COMPATIBLE_VERSIONS_ARRAY ${COMPATIBLE_VERSIONS_LIST})
+set(COMPATIBLE_VERSIONS_ARRAY "{ \"${COMPATIBLE_VERSIONS_ARRAY}\" }")
 list(LENGTH COMPATIBLE_VERSIONS_LIST COMPATIBLE_VERSIONS_COUNT)
 
 add_custom_command(

src/hnsw/utils.c

@@ -22,9 +22,9 @@
 #include "usearch_storage.hpp"
 #include "version.h"
 
-bool  version_checked = false;
-bool  versions_match = true;
-char *catalog_version = "unknown";
+bool version_checked = false;
+bool versions_match = false;
+char catalog_version[ NAMEDATALEN ] = "unknown";
 
 static const char *COMPATIBLE_VERSIONS[ LDB_COMPATIBLE_VERSIONS_COUNT ] = LDB_COMPATIBLE_VERSIONS;
 
@@ -189,12 +189,7 @@ void CheckExtensionVersions()
 
     // Grab the result and check that it matches the version in the generated header
     version_text = DatumGetTextP(val);
-    catalog_version = text_to_cstring(version_text);
-
-    if(strlen(catalog_version) == 0) {
-        SPI_finish();
-        return;
-    }
+    strncpy(catalog_version, text_to_cstring(version_text), NAMEDATALEN);
 
     if(strcmp(catalog_version, LDB_BINARY_VERSION) == 0) {
         versions_match = true;