Updates the CI, unit test

- fixes unit tests (for phpunit 7+)
- min PHP version is 7.2
- CI updates (added Scrutinizer)
- removes a double key verification
- cleanup

Author: kodeart

.gitignore

@@ -1,4 +1,5 @@
 build
 vendor
 .idea
-composer.lock
+composer.lock
+*.cache

.scrutinizer.yml

@@ -0,0 +1,22 @@
+build:
+  nodes:
+    analysis:
+      tests:
+        stop_on_failure: true
+        override:
+          - php-scrutinizer-run
+      environment:
+        php:
+          version: '7.2'
+  dependencies:
+    override:
+      - composer install --no-interaction --prefer-source
+
+filter:
+  excluded_paths:
+    - 'Tests/'
+    - 'vendor/'
+
+tools:
+  php_analyzer: true
+  external_code_coverage: true

.travis.yml

@@ -36,4 +36,4 @@ script:
   - vendor/bin/phpunit --coverage-clover build/coverage/clover.xml
 
 after_success:
-  - travis_retry vendor/bin/codacycoverage clover build/coverage/clover.xml
+  - travis_retry vendor/bin/ocular code-coverage:upload --format=php-clover build/coverage/clover.xml

CacheItem.php

@@ -10,7 +10,7 @@ abstract class CacheItem implements CacheItemInterface
     /** @var bool */
     protected $isHit = false;
 
-    /** @var string */
+    /** @var string Expects a valid cache key name */
     private $key;
 
     /** @var mixed */
@@ -22,7 +22,6 @@ abstract class CacheItem implements CacheItemInterface
 
     public function __construct($key, ?int $ttl)
     {
-        verify_key($key);
         $this->key = $key;
         $this->expiresAt = $ttl;
     }

CacheItemPool.php

@@ -23,7 +23,6 @@ public function __destruct()
     {
         $this->commit();
     }
-
     // @codeCoverageIgnoreEnd
 
     public function commit(): bool
@@ -70,7 +69,6 @@ public function getItem($key): CacheItemInterface
 
             (function() {
                 $this->isHit = true;
-
                 return $this;
             })->call($item);
 

README.md

@@ -3,8 +3,8 @@ Koded - Extended Caching Library
 
 [![Latest Stable Version](https://img.shields.io/packagist/v/koded/cache-extended.svg)](https://packagist.org/packages/koded/cache-extended)
 [![Build Status](https://travis-ci.org/kodedphp/cache-extended.svg?branch=master)](https://travis-ci.org/kodedphp/cache-extended)
-[![Codacy Badge](https://api.codacy.com/project/badge/Coverage/f1aefebb27b1485dbeb2b00ffe7c77fc)](https://www.codacy.com/app/kodeart/cache-extended)
-[![Codacy Badge](https://api.codacy.com/project/badge/Grade/f1aefebb27b1485dbeb2b00ffe7c77fc)](https://www.codacy.com/app/kodeart/cache-extended)
+[![Code Coverage](https://scrutinizer-ci.com/g/kodedphp/cache-extended/badges/coverage.png?b=master)](https://scrutinizer-ci.com/g/kodedphp/cache-extended/?branch=master)
+[![Scrutinizer Code Quality](https://scrutinizer-ci.com/g/kodedphp/cache-extended/badges/quality-score.png?b=master)](https://scrutinizer-ci.com/g/kodedphp/cache-extended/?branch=master)
 [![Minimum PHP Version](https://img.shields.io/badge/php-%3E%3D%207.2-8892BF.svg)](https://php.net/)
 [![Software license](https://img.shields.io/badge/License-BSD%203--Clause-blue.svg)](LICENSE)
 

VERSION

@@ -1 +1 @@
-1.2.0
+1.2.1

composer.json

@@ -16,7 +16,7 @@
   "authors": [
     {
       "name": "Mihail Binev",
-      "homepage": "http://kodeart.com"
+      "homepage": "https://kodeart.com"
     }
   ],
   "prefer-stable": true,
@@ -42,10 +42,10 @@
   },
   "require-dev": {
     "phpunit/phpunit": "~7",
-    "mikey179/vfsStream": "~1",
+    "mikey179/vfsstream": "~1",
     "predis/predis": "dev-master",
     "cache/integration-tests": "dev-master",
-    "codacy/coverage": "dev-master",
+    "scrutinizer/ocular": "^1.6",
     "symfony/phpunit-bridge": "^4.4@dev"
   },
   "extra": {