Corentin spotted some issues with tests 3, 11, and 31; their behavior is confusing.
There are two issues at play here. One (and this is true for most test cases) the baseIRI (either attached to the triples map, or given to the engine as a parameter) is not specified. From tests 11 and 31, one could think that the base IRI of the mapping is http://, but that should be specified. This explains why:
- for 11,
VENUS is not an absolute IRI and the engine tests whether http:// + VENUS is an absolute IRI
- for 31,
WWW.EXAMPLE.COM is not an absolute IRI and the engine tests whether http:// + WWW.EXAMPLE.COM is an absolute IRI
A second issue is that the function toUpperCaseURL has no specification. How is it different from toUpperCase? It is not related to yielding an error if no valid URL is passed, because that would have then failed on VENUS and WWW.EXAMPLE.COM. And, if people are not careful, they might think that the function prepends http:// in lowercase if it is missing.
Proposed solutions:
Corentin spotted some issues with tests 3, 11, and 31; their behavior is confusing.
There are two issues at play here. One (and this is true for most test cases) the baseIRI (either attached to the triples map, or given to the engine as a parameter) is not specified. From tests 11 and 31, one could think that the base IRI of the mapping is
http://, but that should be specified. This explains why:VENUSis not an absolute IRI and the engine tests whetherhttp://+VENUSis an absolute IRIWWW.EXAMPLE.COMis not an absolute IRI and the engine tests whetherhttp://+WWW.EXAMPLE.COMis an absolute IRIA second issue is that the function
toUpperCaseURLhas no specification. How is it different fromtoUpperCase? It is not related to yielding an error if no valid URL is passed, because that would have then failed onVENUSandWWW.EXAMPLE.COM. And, if people are not careful, they might think that the function prependshttp://in lowercase if it is missing.Proposed solutions:
http://for minimal changes, ideally something better.toUpperCaseURL(in the README of the test case) OR use a different function.