image previews not working on st

[Stormtroppy]

Describe the bug
With ueberzugpp enabled and with image previews on, there is nothing on the images side or the search side

To Reproduce
Steps to reproduce the behavior:

1. With st, have use_ueberzugpp=true and run lobster -i

Expected behavior
There should be images on the right side and entries on the left

Screenshots

Desktop (please complete the following information):

• OS: Gentoo
• Terminal: ST

[pitsi]

I think the issue here is that the -i/--image-preview parameter breaks lobster and makes it return no results. I do not use ueberzugpp, just chafa and a terminal with sixel support.

Urxvt, i.e. no sixel support, thus chafa uses symbols

And mlterm, i.e. sixel support and thus chafa uses it instead

But the results are the same as yours, no matter the terminal.

Debug log for further investigation
lobster.log

p.s. Judging from the file names and paths lobster expects to find for the images, I think something messes them up (lines 81, 91, 101 and 111) and leads to the issue.

[SheeperGit]

There is a logic bug that sets the $use_ueberzugpp variable to false, despite the ueberzugpp command being available.
See the following partial git diff below for details on a workaround:

@@ -311,8 +311,8 @@ EOF
     }
     choose_media() {
         if [ "$image_preview" = "true" ]; then
-            if [ "$use_external_menu" = "false" ] && [ "$use_ueberzugpp" = "true" ]; then
-                command -v "ueberzugpp" >/dev/null || send_notification "Please install ueberzugpp if you want to use it for image previews"
+            if [ "$use_external_menu" = "false" ] && [ "$use_ueberzugpp" = "true" ] && ! command -v "ueberzugpp" >/dev/null; then
+                send_notification "Please install ueberzugpp if you want to use it for image previews"
                 use_ueberzugpp="false"
             fi
             maybe_download_thumbnails "$response"

Feel free to make this change without any attribution.
Consider it as a thanks for making such convenient software. <3

Below is my lobster config file.
~/.config/lobster/lobster_config.sh:

lobster_editor=nvim
player=mpv
provider=Vidcloud
history=1

image_preview=true
use_ueberzugpp=true
preview_window_size=50%
ueberzug_x=$(($(tput cols) - 70))
ueberzug_y=$(($(tput lines) / 10))
ueberzug_max_width=100
ueberzug_max_height=100

An unrelated bug that follows is the script doesn't clean up the layer produced by ueberzugpp when clicking the "Esc" key or sending a SIGINT via Ctrl+C.

For example, clicking the "Esc" key in the fzf menu does not remove the layer and hangs the script:

[pitsi]

On my end, the last update to v4.6.5 finally fixed the -i parameter issue that i mentioned above.

And now I get previews on rofi (from which I can not get a screenshot smh), urxvt and alacritty which do not support sixel so images are rendered like this

but not on mlterm, which does support sixel