Skip to content

Deprecate @CsvSource.textBlock in favour of .value[] #5887

Description

@mpkorstanje

Since #4339 it is possible to use @CsvSource.value[] with text blocks. We want to deprecate @CsvSource.textBlock for removal so there's a single option: value which can be used with a text blocks or regular strings. Functionally value[] and textBlock are not identical. textBlock skips comment lines while value[] rejects these (after #5886). So enabling comments for value[] is safe provided users first upgrade to the latest v6.x.

Deliverables

  • Allow comments in @CsvSource.value[]
  • Deprecate @CsvSource.textBlockfor removal
  • Update our docs to use value[] instead of textBlock
  • Update our tests to use value[] instead of textBlock (except textBlock tests).
  • Document in the migration guide that users should upgrade to the latest v6.x before upgrading to v7.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions