revert: default setup of Context As Service

- fix #3754

Author: jknack

docs/asciidoc/router-options.adoc

@@ -16,6 +16,7 @@ import io.jooby.Jooby;
         .setNormalizeSlash(true)
         .setResetHeadersOnError(false)
         .setTrustProxy(true)
+        .setContextAsService(true)
   );
 }
 ----
@@ -33,6 +34,7 @@ import io.jooby.Jooby
     normalizeSlash = true
     resetHeadersOnError = false
     trustProxy = true
+    contextAsService = true
   }
 }
 ----
@@ -41,6 +43,11 @@ import io.jooby.Jooby
 |===
 | Option | Value | Default Value| Description
 
+|contextAsService
+|boolean
+|false
+|If enabled, allows to retrieve the javadoc:Context[] object associated with the current request via the service registry while the request is being processed.
+
 |ignoreCase
 |boolean
 |false
@@ -69,7 +76,7 @@ import io.jooby.Jooby
 |trustProxy
 |boolean
 |false
-|When true handles X-Forwarded-* headers by updating the values on the current context to match what was sent in the header(s).
+|When true handles `X-Forwarded-*` headers by updating the values on the current context to match what was sent in the header(s).
 
 |===
 

jooby/src/main/java/io/jooby/RouterOptions.java

@@ -65,6 +65,35 @@ public class RouterOptions {
    */
   private boolean trustProxy;
 
+  /**
+   * If enabled, allows to retrieve the {@link Context} object associated with the current request
+   * via the service registry while the request is being processed.
+   */
+  private boolean contextAsService;
+
+  /**
+   * If enabled, allows to retrieve the {@link Context} object associated with the current request
+   * via the service registry while the request is being processed.
+   *
+   * @return If enabled, allows to retrieve the {@link Context} object associated with the current
+   *     request via the service registry while the request is being processed.
+   */
+  public boolean isContextAsService() {
+    return contextAsService;
+  }
+
+  /**
+   * If enabled, allows to retrieve the {@link Context} object associated with the current request
+   * via the service registry while the request is being processed.
+   *
+   * @param contextAsService True for enabled.
+   * @return This options.
+   */
+  public RouterOptions setContextAsService(boolean contextAsService) {
+    this.contextAsService = contextAsService;
+    return this;
+  }
+
   /**
    * Indicates whenever routing algorithm does case-sensitive matching on an incoming request path.
    * Default is <code>false (case sensitive)</code>.

jooby/src/main/java/io/jooby/internal/RouterImpl.java

@@ -537,7 +537,7 @@ private void pureAscii(String pattern, Consumer<String> consumer) {
   @NonNull public Router start(@NonNull Jooby app, @NonNull Server server) {
     started = true;
     configureTrustProxy(routerOptions.isTrustProxy());
-    setContextAsService();
+    configureContextAsService(routerOptions.isContextAsService());
     var globalErrHandler = defineGlobalErrorHandler(app);
     if (err == null) {
       err = globalErrHandler;
@@ -610,6 +610,13 @@ private void pureAscii(String pattern, Consumer<String> consumer) {
     return this;
   }
 
+  private void configureContextAsService(boolean contextAsService) {
+    if (contextAsService) {
+      addPostDispatchInitializer(ContextAsServiceInitializer.INSTANCE);
+      getServices().put(Context.class, ContextAsServiceInitializer.INSTANCE);
+    }
+  }
+
   /**
    * Define the global error handler. If ProblemDetails is enabled the {@link ProblemDetailsHandler}
    * instantiated from configuration settings and returned. Otherwise, {@link DefaultErrorHandler}
@@ -802,13 +809,6 @@ public Router setCurrentUser(@NonNull Function<Context, Object> provider) {
     return this;
   }
 
-  private Router setContextAsService() {
-    addPostDispatchInitializer(ContextAsServiceInitializer.INSTANCE);
-    getServices().put(Context.class, ContextAsServiceInitializer.INSTANCE);
-
-    return this;
-  }
-
   @Override
   public String toString() {
     StringBuilder buff = new StringBuilder();

tests/src/test/java/io/jooby/i1937/Issue1937.java

@@ -9,12 +9,28 @@
 import static org.junit.jupiter.api.Assertions.assertThrows;
 
 import io.jooby.Context;
+import io.jooby.RouterOptions;
 import io.jooby.exception.RegistryException;
+import io.jooby.guice.GuiceModule;
 import io.jooby.junit.ServerTest;
 import io.jooby.junit.ServerTestRunner;
 
 public class Issue1937 {
 
+  @ServerTest
+  public void shouldFailIfContextAsServiceWasNotCalled(ServerTestRunner runner) {
+    runner
+        .define(
+            app ->
+                app.get(
+                    "/i1937",
+                    ctx -> {
+                      app.require(Context.class);
+                      return "OK";
+                    }))
+        .ready(http -> http.get("/i1937", rsp -> assertEquals(500, rsp.code())));
+  }
+
   @ServerTest
   public void shouldWorkIfContextAsServiceWasCalled(ServerTestRunner runner) {
     runner
@@ -26,6 +42,8 @@ public void shouldWorkIfContextAsServiceWasCalled(ServerTestRunner runner) {
                     app.require(Context.class);
                     return "OK";
                   });
+
+              app.setRouterOptions(new RouterOptions().setContextAsService(true));
             })
         .ready(http -> http.get("/i1937", rsp -> assertEquals(200, rsp.code())));
   }
@@ -35,6 +53,26 @@ public void shouldThrowIfOutOfScope(ServerTestRunner runner) {
     runner
         .define(
             app -> {
+              app.setRouterOptions(new RouterOptions().setContextAsService(true));
+              app.onStarted(
+                  () -> {
+                    Throwable t =
+                        assertThrows(RegistryException.class, () -> app.require(Context.class));
+                    assertEquals(
+                        t.getMessage(),
+                        "Context is not available. Are you getting it from request scope?");
+                  });
+            })
+        .ready(http -> {});
+  }
+
+  @ServerTest
+  public void shouldThrowIfOutOfScopeWithDI(ServerTestRunner runner) {
+    runner
+        .define(
+            app -> {
+              app.install(new GuiceModule());
+              app.setRouterOptions(new RouterOptions().setContextAsService(true));
               app.onStarted(
                   () -> {
                     Throwable t =