build: unit tests for jsonrpc

Author: jknack

modules/jooby-jsonrpc/pom.xml

@@ -25,5 +25,20 @@
       <version>${jooby.version}</version>
       <optional>true</optional>
     </dependency>
+    <dependency>
+      <groupId>org.junit.jupiter</groupId>
+      <artifactId>junit-jupiter-api</artifactId>
+      <scope>test</scope>
+    </dependency>
+    <dependency>
+      <groupId>org.mockito</groupId>
+      <artifactId>mockito-core</artifactId>
+      <scope>test</scope>
+    </dependency>
+    <dependency>
+      <groupId>org.mockito</groupId>
+      <artifactId>mockito-junit-jupiter</artifactId>
+      <scope>test</scope>
+    </dependency>
   </dependencies>
 </project>

modules/jooby-jsonrpc/src/main/java/io/jooby/jsonrpc/JsonRpcErrorCode.java

@@ -5,6 +5,8 @@
  */
 package io.jooby.jsonrpc;
 
+import java.util.Objects;
+
 import io.jooby.StatusCode;
 
 /**
@@ -132,7 +134,7 @@ public boolean isProtocol() {
    */
   public static JsonRpcErrorCode of(StatusCode status) {
     for (var errorCode : values()) {
-      if (!errorCode.protocol && errorCode.statusCode.value() == status.value()) {
+      if (!errorCode.protocol && Objects.equals(errorCode.statusCode, status)) {
         return errorCode;
       }
     }

modules/jooby-jsonrpc/src/main/java/io/jooby/jsonrpc/JsonRpcModule.java

@@ -42,12 +42,12 @@
  * {
  * install(new Jackson3Module());
  * install(new JsonRpcJackson3Module());
- * * install(new JsonRpcModule(new MyServiceRpc_())
+ * install(new JsonRpcModule(new MyServiceRpc_())
  * .invoker(new MyJsonRpcMiddleware()));
  * }
  * }</pre>
  *
- * @author Edgar Espina
+ * @author edgar
  * @since 4.0.17
  */
 public class JsonRpcModule implements Extension {
@@ -83,12 +83,14 @@ public JsonRpcModule(JsonRpcService service, JsonRpcService... services) {
   /**
    * Adds a {@link JsonRpcInvoker} middleware to the execution pipeline.
    *
-   * <p>Middlewares are composed together to form a {@link JsonRpcChain}. When multiple invokers are
-   * registered, they wrap around each other, meaning the first added invoker will execute first.
+   * <p>Execution order follows a First-In-First-Out (FIFO) pipeline. When multiple invokers are
+   * registered, they wrap around each other in the order they were added. <br>
+   * For example: {@code .invoker(A).invoker(B)} generates the pipeline {@code A -> B}.
    *
    * <p><strong>Tracing Priority:</strong> If the provided invoker is an instance of {@link
    * OtelJsonRcpTracing}, it is automatically promoted to the absolute head of the pipeline. This
-   * guarantees that OpenTelemetry spans encompass all other middlewares and the final execution.
+   * guarantees that OpenTelemetry spans encompass all other middlewares and the final execution
+   * regardless of the order it was added.
    *
    * @param invoker The middleware interceptor to add to the pipeline.
    * @return This module instance for fluent configuration chaining.
@@ -99,7 +101,8 @@ public JsonRpcModule invoker(JsonRpcInvoker invoker) {
       this.head = otel;
     } else {
       if (this.invoker != null) {
-        this.invoker = invoker.then(this.invoker);
+        // Appends to the chain to ensure First-In-First-Out (A -> B)
+        this.invoker = this.invoker.then(invoker);
       } else {
         this.invoker = invoker;
       }

modules/jooby-jsonrpc/src/main/java/io/jooby/jsonrpc/instrumentation/OtelJsonRcpTracing.java

@@ -45,8 +45,6 @@
  * @since 4.5.0
  */
 public class OtelJsonRcpTracing implements JsonRpcInvoker {
-  private final OpenTelemetry otel;
-
   private final Tracer tracer;
 
   private SneakyThrows.@Nullable Consumer3<Context, JsonRpcRequest, Span> onStart;
@@ -59,7 +57,6 @@ public class OtelJsonRcpTracing implements JsonRpcInvoker {
    * @param otel The OpenTelemetry instance used to obtain the tracer.
    */
   public OtelJsonRcpTracing(OpenTelemetry otel) {
-    this.otel = otel;
     tracer = otel.getTracer("io.jooby.jsonrpc");
   }