java 8 + nashorn

- remove rhino
- set code base 1.8
- fix #626 #625 #529

Author: jknack

handlebars-jdk8-tests/pom.xml

@@ -1 +1 @@
-hello=Hello!
+hello=Hello!

handlebars-jdk8-tests/src/test/java/com/github/jknack/handlebars/TypeSafeTemplateDefaultMethodTest.java

@@ -1 +1 @@
-hello=Hola!
+hello=Hola!

handlebars-maven-plugin-tests/src/main/resources/messages.properties

@@ -38,7 +38,7 @@
     <dependency>
       <groupId>org.apache.maven</groupId>
       <artifactId>maven-plugin-api</artifactId>
-      <version>3.0.4</version>
+      <version>3.5.3</version>
     </dependency>
 
     <dependency>
@@ -50,13 +50,13 @@
     <dependency>
       <groupId>org.apache.maven</groupId>
       <artifactId>maven-core</artifactId>
-      <version>3.1.0</version>
+      <version>3.5.3</version>
     </dependency>
 
     <dependency>
       <groupId>org.apache.maven.plugin-tools</groupId>
       <artifactId>maven-plugin-annotations</artifactId>
-      <version>3.2</version>
+      <version>3.5.2</version>
       <scope>provided</scope>
     </dependency>
 
@@ -69,9 +69,16 @@
     <dependency>
       <groupId>com.google.javascript</groupId>
       <artifactId>closure-compiler</artifactId>
-      <version>v20130603</version>
+      <version>v20180506</version>
     </dependency>
 
+    <dependency>
+      <groupId>com.google.guava</groupId>
+      <artifactId>guava</artifactId>
+      <version>21.0</version>
+    </dependency>
+
+
     <!-- Test dependencies -->
     <dependency>
       <groupId>junit</groupId>
@@ -91,7 +98,7 @@
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-plugin-plugin</artifactId>
-        <version>3.2</version>
+        <version>3.5.2</version>
         <configuration>
           <!-- see http://jira.codehaus.org/browse/MNG-5346 -->
           <skipErrorNoDescriptorsFound>true</skipErrorNoDescriptorsFound>

handlebars-maven-plugin-tests/src/main/resources/messages_es_AR.properties

@@ -66,9 +66,7 @@ public void setProject(final MavenProject project) {
   public final void execute() throws MojoExecutionException, MojoFailureException {
     try {
       doExecute();
-    } catch (MojoExecutionException ex) {
-      throw ex;
-    } catch (MojoFailureException ex) {
+    } catch (MojoExecutionException | MojoFailureException ex) {
       throw ex;
     } catch (RuntimeException ex) {
       throw new MojoExecutionException(ex.getMessage(), ex);

handlebars-maven-plugin/pom.xml

@@ -37,6 +37,7 @@
 import java.io.File;
 import java.net.URL;
 import java.net.URLClassLoader;
+import java.nio.charset.Charset;
 import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.LinkedHashSet;
@@ -110,6 +111,7 @@ protected void doExecute() throws Exception {
     notNull(output, "The output parameter is required.");
 
     Handlebars handlebars = new Handlebars();
+    handlebars.setCharset(Charset.forName(encoding));
     Context context = Context.newContext(null);
     URL[] classpath = projectClasspath();
 

handlebars-maven-plugin/src/main/java/com/github/jknack/handlebars/maven/HandlebarsPlugin.java

@@ -40,6 +40,7 @@
 import java.io.InputStream;
 import java.io.PrintWriter;
 import java.net.URL;
+import java.nio.charset.Charset;
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Collections;
@@ -155,6 +156,7 @@ protected void doExecute() throws Exception {
 
       Handlebars handlebars = new Handlebars(new FileTemplateLoader(basedir, suffix));
       handlebars.handlebarsJsFile(handlebarsJsFile);
+      handlebars.setCharset(Charset.forName(encoding));
 
       final List<CharSequence> extras = new ArrayList<CharSequence>();
 
@@ -354,7 +356,7 @@ private CharSequence registerHelper(final String name, final String body, final
   private void minimize(final File output) throws IOException, MojoFailureException {
     final CompilerOptions options = new CompilerOptions();
     options.setCodingConvention(new ClosureCodingConvention());
-    options.setOutputCharset("UTF-8");
+    options.setOutputCharset(Charset.forName(encoding));
     options.setWarningLevel(DiagnosticGroups.CHECK_VARIABLES, CheckLevel.WARNING);
     CompilationLevel.SIMPLE_OPTIMIZATIONS.setOptionsForCompilationLevel(options);
 

handlebars-maven-plugin/src/main/java/com/github/jknack/handlebars/maven/I18nJsPlugin.java

@@ -1 +1 @@
-version=${project.version}
+version=${project.version}

handlebars-maven-plugin/src/main/java/com/github/jknack/handlebars/maven/PrecompilePlugin.java

@@ -529,7 +529,7 @@ public HandlebarsViewResolver registerHelpers(final String filename, final Input
 
   @Override
   public HandlebarsViewResolver registerHelpers(final String filename, final String source)
-      throws Exception {
+      throws IOException {
     registry.registerHelpers(filename, source);
     return this;
   }