Force MapValueResolver fix #654

Author: jknack

handlebars/src/main/java/com/github/jknack/handlebars/Context.java

@@ -29,7 +29,9 @@
 import java.util.Map;
 import java.util.Map.Entry;
 import java.util.Set;
+import java.util.stream.Stream;
 
+import com.github.jknack.handlebars.context.MapValueResolver;
 import com.github.jknack.handlebars.internal.path.ThisPath;
 import com.github.jknack.handlebars.io.TemplateSource;
 
@@ -290,7 +292,15 @@ public Builder combine(final Map<String, ?> model) {
      */
     public Builder resolver(final ValueResolver... resolvers) {
       notEmpty(resolvers, "At least one value-resolver must be present.");
-      context.setResolver(new CompositeValueResolver(resolvers));
+      boolean mapResolver = Stream.of(resolvers).anyMatch(MapValueResolver.class::isInstance);
+      if (!mapResolver) {
+        ValueResolver[] safeResolvers = new ValueResolver[resolvers.length + 1];
+        System.arraycopy(resolvers, 0, safeResolvers, 0, resolvers.length);
+        safeResolvers[safeResolvers.length - 1] = MapValueResolver.INSTANCE;
+        context.setResolver(new CompositeValueResolver(safeResolvers));
+      } else {
+        context.setResolver(new CompositeValueResolver(resolvers));
+      }
       return this;
     }
 

handlebars/src/test/java/com/github/jknack/handlebars/issues/Issue654.java

@@ -0,0 +1,29 @@
+package com.github.jknack.handlebars.issues;
+
+import com.github.jknack.handlebars.Context;
+import com.github.jknack.handlebars.context.JavaBeanValueResolver;
+import com.github.jknack.handlebars.context.MapValueResolver;
+import com.github.jknack.handlebars.v4Test;
+import org.junit.Test;
+
+import static org.junit.Assert.assertEquals;
+
+public class Issue654 extends v4Test {
+
+  @Test
+  public void makeSureMapResolverIsAlwaysPresent() throws Exception {
+    Context ctx = Context.newBuilder($("foo", "bar"))
+        .resolver(JavaBeanValueResolver.INSTANCE)
+        .build();
+    assertEquals("bar", ctx.get("foo"));
+  }
+
+  @Test
+  public void ignoreMapResolverWhenItIsProvided() throws Exception {
+    Context ctx = Context.newBuilder($("foo", "bar"))
+        .resolver(MapValueResolver.INSTANCE)
+        .build();
+    assertEquals("bar", ctx.get("foo"));
+  }
+
+}