chore: Minor Formatting/cleanup

Author: bartelink

src/FsCodec.NewtonsoftJson/UnionConverter.fs

@@ -13,7 +13,7 @@ module private UnionInfo =
         t = typeof<string>
         || t.IsValueType
         || t.IsArray
-        || (t.IsGenericType && let g = t.GetGenericTypeDefinition() in typedefof<Option<_>> = g || g.IsValueType) // Nullable<T>
+        || (t.IsGenericType && let g = t.GetGenericTypeDefinition() in typedefof<option<_>> = g || g.IsValueType) // Nullable<T>, ValueOption<T>
 
     let hasConverterCache = System.Collections.Concurrent.ConcurrentDictionary<Type, bool>()
     let typeHasConverterAttribute (t: Type) = hasConverterCache.GetOrAdd(t, fun t -> t.IsDefined(typeof<JsonConverterAttribute>, ``inherit`` = false))

src/FsCodec.SystemTextJson/Options.fs

@@ -70,8 +70,7 @@ type Options private () =
                 if rejectNullStrings then RejectNullStringConverter()
                 if autoTypeSafeEnumToJsonString || autoUnionToJsonObject then
                     UnionOrTypeSafeEnumConverterFactory(typeSafeEnum = autoTypeSafeEnumToJsonString, union = autoUnionToJsonObject)
-                if converters <> null then yield! converters
-            |],
+                if converters <> null then yield! converters |],
             ?ignoreNulls = ignoreNulls,
             ?indent = indent,
             ?camelCase = camelCase,

src/FsCodec.SystemTextJson/RejectNullStringConverter.fs

@@ -6,7 +6,7 @@ type RejectNullStringConverter() =
     let  [<Literal>] message = "Expected string, got null. When allowNullStrings is false you must explicitly type optional strings as 'string option'"
 
     override _.HandleNull = true
-    override _.CanConvert(t) = t = typeof<string>
+    override _.CanConvert t = t = typeof<string>
 
     override this.Read(reader, _typeToConvert, _options) =
         let value = reader.GetString()

src/FsCodec.SystemTextJson/TypeSafeEnumConverter.fs

@@ -1,22 +1,18 @@
 namespace FsCodec.SystemTextJson
 
-open System
 open System.Text.Json
 
 /// Maps strings to/from Union cases; refuses to convert for values not in the Union
 type TypeSafeEnumConverter<'T>() =
     inherit Serialization.JsonConverter<'T>()
 
-    override _.CanConvert(t: Type) =
-        let tt = typedefof<'T>
-        t = tt && FsCodec.Union.isUnion tt && FsCodec.Union.isNullary tt
+    override _.CanConvert t =
+        t = typeof<'T> && FsCodec.Union.isUnion t && FsCodec.Union.isNullary t
 
     override _.Write(writer, value, _options) =
-        let str = FsCodec.TypeSafeEnum.toString value
-        writer.WriteStringValue str
+        value |> FsCodec.TypeSafeEnum.toString |> writer.WriteStringValue
 
     override _.Read(reader, _t, _options) =
         if reader.TokenType <> JsonTokenType.String then
             sprintf "Unexpected token when reading TypeSafeEnum: %O" reader.TokenType |> JsonException |> raise
-        let str = reader.GetString()
-        FsCodec.TypeSafeEnum.parse<'T> str
+        reader.GetString() |> FsCodec.TypeSafeEnum.parse<'T>

src/FsCodec.SystemTextJson/UnionConverter.fs

@@ -26,7 +26,7 @@ type UnionConverter<'T>() =
     let converterOptions = UnionConverterOptions.get typeof<'T>
     let info = FsCodec.Union.Info.get typeof<'T>
 
-    override _.CanConvert(t: Type) = t = typeof<'T> && FsCodec.Union.isUnion t
+    override _.CanConvert t = t = typeof<'T> && FsCodec.Union.isUnion t
 
     override _.Write(writer: Utf8JsonWriter, value, options: JsonSerializerOptions) =
         let value = box value
@@ -59,7 +59,7 @@ type UnionConverter<'T>() =
             match findCaseNamed inputCaseNameValue, converterOptions.CatchAllCase  with
             | None, null ->
                 sprintf "No case defined for '%s', and no catchAllCase nominated for '%s' on type '%s'"
-                    inputCaseNameValue typeof<UnionConverter<_>>.Name t.FullName |> invalidOp
+                    inputCaseNameValue typeof<UnionConverter<'T>>.Name t.FullName |> invalidOp
             | Some c, _ -> c
             | None, catchAllCaseName ->
                 match findCaseNamed catchAllCaseName with