Skip to content

Commit 32c152c

Browse files
committed
Relax FSharp.Core dep back to 4.3.4
1 parent 61eed31 commit 32c152c

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@ The `Unreleased` section name is replaced by the expected version of next releas
1010

1111
### Added
1212
### Changed
13+
14+
- `SystemTextJson`: Target `TypeShape` v `9.0.0` in order to reinstate support for `FSharp.Core` v `4.3.4`
15+
1316
### Removed
1417
### Fixed
1518

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ The components within this repository are delivered as multi-targeted Nuget pack
2121
- Provides relevant Converters for common non-primitive types prevalent in F#
2222
- [depends](https://www.fuget.org/packages/FsCodec.NewtonsoftJson) on `FsCodec`, `Newtonsoft.Json >= 11.0.2`, `TypeShape >= 8`, `Microsoft.IO.RecyclableMemoryStream >= 1.2.2`, `System.Buffers >= 4.5`
2323
- [![System.Text.Json Codec NuGet](https://img.shields.io/nuget/v/FsCodec.SystemTextJson.svg)](https://www.nuget.org/packages/FsCodec.SystemTextJson/) `FsCodec.SystemTextJson`: See [#38](https://github.com/jet/FsCodec/pulls/38): drop in replacement that allows one to retarget from `Newtonsoft.Json` to the .NET Core >= v 3.0 default serializer: `System.Text.Json`, solely by changing the referenced namespace.
24-
- [depends](https://www.fuget.org/packages/FsCodec.SystemTextJson) on `FsCodec`, `System.Text.Json >= 6.0.1`, `TypeShape >= 10`
24+
- [depends](https://www.fuget.org/packages/FsCodec.SystemTextJson) on `FsCodec`, `System.Text.Json >= 6.0.1`, `TypeShape >= 9`
2525

2626
# Features: `FsCodec`
2727

@@ -74,7 +74,7 @@ The role and intention of the converters in the box in `FsCodec.SystemTextJson`
7474

7575
It's worth calling out explicitly that there are no plans to extend the representations `FsCodec.SystemTextJson` can handle in any significant way over time ([the advice for `FsCodec.NewtonsoftJson` has always been to avoid stuff outside of records, `option`s and `array`s](#recommendations)) - if you have specific exotic corner cases and determine you need something more specifically tailored, the Converters abstraction affords you ability to mix and match as necessary for specific applications.
7676

77-
_The single most complete set of `System.Text.Json` Converters is the [`FSharp.SystemTextJson`](https://github.com/Tarmil/FSharp.SystemTextJson) library; it provides a much broader, well tested set of converters with a broader remit than what FsCodec is trying to succinctly address as its sweet spot._
77+
_The single most complete set of `System.Text.Json` Converters is the [`FSharp.SystemTextJson`](https://github.com/Tarmil/FSharp.SystemTextJson) library; it provides a much broader, well tested set of converters with a broader remit than what FsCodec is trying to succinctly address as its sweet spot. [In general, there should be a smooth path to transition from using FsCodec to that as and when needed](https://github.com/jet/FsCodec/pull/69#issuecomment-1006532703)_
7878

7979
### Core converters
8080

src/FsCodec.SystemTextJson/FsCodec.SystemTextJson.fsproj

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,10 @@
2222
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0" PrivateAssets="All" />
2323
<PackageReference Include="MinVer" Version="2.5.0" PrivateAssets="All" />
2424

25-
<!-- NOTE: Not 4.3.4 as typical, as TypeShape v10 demands higher -->
26-
<PackageReference Include="FSharp.Core" Version="4.5.4" />
25+
<PackageReference Include="FSharp.Core" Version="4.3.4" />
2726

2827
<PackageReference Include="System.Text.Json" Version="6.0.1" />
29-
<PackageReference Include="TypeShape" Version="10.0.0" />
28+
<PackageReference Include="TypeShape" Version="9.0.0" />
3029
</ItemGroup>
3130

3231
<ItemGroup>

0 commit comments

Comments
 (0)