I disagree with the rationale for #38, and the effects of the associated code changes.
Sometimes I put in code comments that are very specific to a particular line; sometimes I adopt code that was not originally in literate. In both cases it would be useful to me to see the comments in the preview; it was surprising when they weren't there.
Perhaps an intermediate solution would be to add an option that controlled whether or not code comments are tossed for HTML.
If you decide to retain the feature anyway, it might be better to eat the comments completely. The whitespace associated with them remains in the HTML output, which is a little weird. I haven't been able to trace exactly how that happens. Perhaps the data-line value in, e.g., <code data-line="233"... is actually controlling the vertical position, and is set before the comment is removed.
I disagree with the rationale for #38, and the effects of the associated code changes.
Sometimes I put in code comments that are very specific to a particular line; sometimes I adopt code that was not originally in
literate. In both cases it would be useful to me to see the comments in the preview; it was surprising when they weren't there.Perhaps an intermediate solution would be to add an option that controlled whether or not code comments are tossed for HTML.
If you decide to retain the feature anyway, it might be better to eat the comments completely. The whitespace associated with them remains in the HTML output, which is a little weird. I haven't been able to trace exactly how that happens. Perhaps the
data-linevalue in, e.g.,<code data-line="233"...is actually controlling the vertical position, and is set before the comment is removed.