fix: terminal UI and entries editor bugs

- Fix terminal_ui to use python_search binary instead of pys for loading entries
- Add entries_editor script to pyproject.toml
- Fix search_actions to use SystemPaths for entries_editor binary
- Add custom window size for entries editor (100x40 chars)
- Fix duplicate remember_window_size setting in terminal params

Author: jeanCarloMachado

pyproject.toml

@@ -69,3 +69,4 @@ term_ui = 'python_search.search.search_ui.terminal_ui:main'
 register_new_launch_ui = 'python_search.entry_capture.entry_inserter_gui.register_new_gui:launch_ui'
 google_it = 'python_search.apps.google_it:main'
 share_entry = 'python_search.share_entry:main'
+entries_editor = 'python_search.entry_capture.entries_editor:main'

python_search/apps/terminal.py

@@ -14,9 +14,8 @@ class KittyTerminal:
     # these parameters are applied both to all kitty windows of pythons search
     # including the generic params and the python search main window
     GLOBAL_TERMINAL_PARAMS = (
-        " -o remember_window_size=yes "
+        " -o remember_window_size=no "
         + " -o confirm_os_window_close=0 "
-        + " -o remember_window_size=n "
         + " -o resize_in_steps=1 "
         + " -o macos_quit_when_last_window_closed=yes "
     )

python_search/entry_capture/entries_editor.py

@@ -70,10 +70,22 @@ def edit_key(self, key_expr: str):
     def edit_default(self):
         import os
 
+        terminal = KittyTerminal()
+        editor_params = (
+            f" {terminal.GLOBAL_TERMINAL_PARAMS} "
+            f" -o initial_window_width={self.EDITOR_WIDTH} "
+            f" -o initial_window_height={self.EDITOR_HEIGHT} "
+            f" -o font_size={self.EDITOR_FONT_SIZE} "
+        )
         os.system(
-            f"kitty vim '{self.configuration.get_project_root() + '/entries_main.py'}'"
+            f"{terminal.get_kitty_cmd()} {editor_params} vim '{self.configuration.get_project_root()}/entries_main.py'"
         )
 
+    # Editor-specific window settings (squared window for editing)
+    EDITOR_WIDTH = "100c"
+    EDITOR_HEIGHT = "40c"
+    EDITOR_FONT_SIZE = 14
+
     def _edit_file(self, file_name: str, line: Optional[int] = 30, dry_run=False):
         """
         edit a configuration file given the name and line
@@ -82,8 +94,15 @@ def _edit_file(self, file_name: str, line: Optional[int] = 30, dry_run=False):
         # @ todo make this editor generic
 
         terminal = KittyTerminal()
+        # Use editor-specific window size instead of generic terminal params
+        editor_params = (
+            f" {terminal.GLOBAL_TERMINAL_PARAMS} "
+            f" -o initial_window_width={self.EDITOR_WIDTH} "
+            f" -o initial_window_height={self.EDITOR_HEIGHT} "
+            f" -o font_size={self.EDITOR_FONT_SIZE} "
+        )
         cmd: str = (
-            f" {terminal.get_kitty_cmd()} {terminal.GENERIC_TERMINAL_PARAMS} "
+            f" {terminal.get_kitty_cmd()} {editor_params} "
             f"bash -c 'cd {self.configuration.get_project_root()} && "
             f"{self._get_open_text_editor_command(file_name, line)}'"
         )

python_search/search/search_ui/search_actions.py

@@ -30,7 +30,7 @@ def edit_key(self, key: str, block: bool = False) -> None:
             key: The identifier for the entry to edit
             block: Whether to block execution (currently unused)
         """
-        cmd = f"/opt/miniconda3/envs/python312/bin/entries_editor " f'edit_key "{key}" &>/dev/null'
+        cmd = SystemPaths.get_binary_full_path("entries_editor") + f' edit_key "{key}" &>/dev/null'
         Popen(cmd, stdout=None, stderr=None, shell=True)
 
     def copy_entry_value_to_clipboard(self, entry_key: str) -> None:

python_search/search/search_ui/terminal_ui.py

@@ -218,7 +218,7 @@ def _setup_entries(self):
         import subprocess
 
         output = subprocess.getoutput(
-            SystemPaths.get_binary_full_path("pys") + " _entries_loader load_entries_as_json 2>/dev/null"
+            SystemPaths.get_binary_full_path("python_search") + " _entries_loader load_entries_as_json 2>/dev/null"
         )
         # print("output", output)
         self.commands = json.loads(output)