-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathparse_test.go
More file actions
685 lines (607 loc) · 16.3 KB
/
Copy pathparse_test.go
File metadata and controls
685 lines (607 loc) · 16.3 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
//lint:file-ignore U1000 Ignore unused code in test file
package structpages
import (
"fmt"
"reflect"
"strings"
"testing"
"github.com/google/go-cmp/cmp"
)
func TestParseTag(t *testing.T) {
tests := []struct {
name string
route string
expected struct {
method string
path string
title string
}
}{
{
name: "Empty route",
route: "",
expected: struct {
//lint:ignore U1000 test field
method string
//lint:ignore U1000 test field
path string
//lint:ignore U1000 test field
title string
}{
method: methodAll,
path: "/",
title: "",
},
},
{
name: "Only path",
route: "/example",
expected: struct {
//lint:ignore U1000 test field
method string
//lint:ignore U1000 test field
path string
//lint:ignore U1000 test field
title string
}{
method: methodAll,
path: "/example",
title: "",
},
},
{
name: "invalid method and path",
route: "INVALID /example",
expected: struct {
//lint:ignore U1000 test field
method string
//lint:ignore U1000 test field
path string
//lint:ignore U1000 test field
title string
}{
method: methodAll,
path: "INVALID",
title: "/example",
},
},
{
name: "Method and path",
route: "POST /example",
expected: struct {
//lint:ignore U1000 test field
method string
//lint:ignore U1000 test field
path string
//lint:ignore U1000 test field
title string
}{
method: "POST",
path: "/example",
title: "",
},
},
{
name: "Method, path, and title",
route: "PUT /example Update Example",
expected: struct {
//lint:ignore U1000 test field
method string
//lint:ignore U1000 test field
path string
//lint:ignore U1000 test field
title string
}{
method: "PUT",
path: "/example",
title: "Update Example",
},
},
{
name: "Invalid method",
route: "INVALID /example Invalid Method",
expected: struct {
//lint:ignore U1000 test field
method string
//lint:ignore U1000 test field
path string
//lint:ignore U1000 test field
title string
}{
method: methodAll,
path: "INVALID",
title: "/example Invalid Method",
},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
method, path, title := parseTag(tt.route)
actual := struct {
//lint:ignore U1000 test field
method string
//lint:ignore U1000 test field
path string
//lint:ignore U1000 test field
title string
}{
method: method,
path: path,
title: title,
}
if !reflect.DeepEqual(actual, tt.expected) {
t.Errorf("parseTag(%q) = %+v, want %+v", tt.route, actual, tt.expected)
}
})
}
}
func TestParseSimple(t *testing.T) {
type topPage struct {
f1 *TestHandlerPage `route:"/ Test Page"`
f2 *TestHandlerPage `route:"/f2 Test Page 2"`
}
pc, err := parsePageTree("/", &topPage{})
if err != nil {
t.Fatalf("parsePageTree failed: %v", err)
}
if pc.root == nil {
t.Fatal("parsePageTree returned nil")
}
s := pc.root.String()
if s == "" {
t.Fatal("Page tree string representation is empty")
}
}
func Test_pc_UrlFor(t *testing.T) {
type topPage struct {
f1 *TestHandlerPage `route:"/f1 Test Page"`
f2 *TestHandlerPage `route:"/f2 Test Page 2"`
}
pc, err := parsePageTree("/", &topPage{})
if err != nil {
t.Fatalf("parsePageTree failed: %v", err)
}
if pc.root == nil {
t.Fatal("parsePageTree returned nil")
}
// Two fields of the same type — always strict, so URLFor errors.
{
_, err := pc.urlFor(&TestHandlerPage{})
if err == nil {
t.Fatal("urlFor expected ambiguous error")
}
}
// Root struct type only matches once, so it resolves cleanly.
{
url, err := pc.urlFor(&topPage{})
if err != nil {
t.Fatalf("urlFor failed: %v", err)
}
if url != "/" {
t.Errorf("Expected URL '/', got '%s'", url)
}
}
}
func Test_parseContext_getArg(t *testing.T) {
str := "test"
type strct struct{}
tests := []struct {
name string
args []any
in reflect.Type
want any
}{
{
name: "Simple type",
args: []any{str},
in: reflect.TypeOf("test"),
want: "test",
},
{
name: "Pointer type",
args: []any{&str},
in: reflect.TypeOf((*string)(nil)),
want: &str,
},
{
name: "save pointer, ask for value",
args: []any{&str},
in: reflect.TypeOf(""),
want: "test",
},
// {
// name: "save value, ask for pointer",
// args: []any{str},
// in: reflect.TypeOf((*string)(nil)),
// want: &str,
// },
{
name: "Struct type",
args: []any{strct{}},
in: reflect.TypeOf(strct{}),
want: strct{},
},
{
name: "Pointer to struct type",
args: []any{&strct{}},
in: reflect.TypeOf((*strct)(nil)),
want: &strct{},
},
{
name: "save pointer to struct, ask for value",
args: []any{&strct{}},
in: reflect.TypeOf((*strct)(nil)).Elem(),
want: strct{},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
args := make(argRegistry)
for _, arg := range tt.args {
if err := args.addArg(arg); err != nil {
t.Fatalf("Failed to add arg: %v", err)
}
}
got, ok := args.getArg(tt.in)
if !ok {
t.Errorf("getArg() did not find type %v", tt.in)
return
}
if diff := cmp.Diff(got.Interface(), tt.want); diff != "" {
t.Errorf("getArg() mismatch (-got +want):\n%s", diff)
}
})
}
}
// Test parsePageTree field skipping
func TestParsePageTree_skipFields(t *testing.T) {
// Struct with fields that should be skipped
type pageWithSkippedFields struct {
// Field without route tag - should be skipped
NotARoute string
// Exported field to test - but string fields cause error
Page struct{} `route:"/page Page"`
}
pc, err := parsePageTree("/", &pageWithSkippedFields{})
if err != nil {
t.Fatal(err)
}
// Should have one child for the exported field with route tag
if len(pc.root.Children) != 1 {
t.Errorf("Expected 1 child, got %d", len(pc.root.Children))
}
}
// Types for testing
type pageWithNoReturn struct{}
func (p *pageWithNoReturn) NoReturn() {
// Returns nothing
}
// Test callComponentMethod with no results
func TestParseContext_callComponentMethod_noResults(t *testing.T) {
pc := &parseContext{args: make(argRegistry)}
pn := &PageNode{
Name: "test",
Value: reflect.ValueOf(&pageWithNoReturn{}),
}
method, _ := reflect.TypeOf(&pageWithNoReturn{}).MethodByName("NoReturn")
// This should return error because no results
_, err := pc.callComponentMethod(pn, &method)
if err == nil {
t.Error("Expected error from callComponentMethod with no return value")
}
}
// Test parsePageTree error cases
func TestParsePageTree_errors(t *testing.T) {
// Test with duplicate argument types
type testStruct struct{ Value string }
arg1 := &testStruct{Value: "first"}
arg2 := &testStruct{Value: "second"}
_, err := parsePageTree("/", struct{}{}, arg1, arg2)
if err == nil {
t.Error("Expected error for duplicate argument types")
}
}
// Test parsePageTree with non-struct input
func TestParsePageTree_nonStruct(t *testing.T) {
tests := []struct {
name string
input any
wantErr bool
}{
{
name: "string input",
input: "not a struct",
wantErr: true,
},
{
name: "slice input",
input: []string{"a", "b"},
wantErr: true,
},
{
name: "map input",
input: map[string]int{"a": 1},
wantErr: true,
},
{
name: "nil input",
input: nil,
wantErr: true,
},
{
name: "int input",
input: 42,
wantErr: true,
},
{
name: "valid struct",
input: struct{}{},
wantErr: false,
},
{
name: "pointer to struct",
input: &struct{}{},
wantErr: false,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
_, err := parsePageTree("/", tt.input)
if (err != nil) != tt.wantErr {
t.Errorf("parsePageTree() error = %v, wantErr %v", err, tt.wantErr)
}
})
}
}
type pageWithWrongReturn struct{}
func (p *pageWithWrongReturn) WrongReturn() string {
return "not a component"
}
// Test callComponentMethod error case
func TestParseContext_callComponentMethod_wrongReturnType(t *testing.T) {
pc := &parseContext{args: make(argRegistry)}
pn := &PageNode{
Name: "test",
Value: reflect.ValueOf(&pageWithWrongReturn{}),
}
method, _ := reflect.TypeOf(&pageWithWrongReturn{}).MethodByName("WrongReturn")
// This should return error because return type is not component
_, err := pc.callComponentMethod(pn, &method)
if err == nil {
t.Error("Expected error from callComponentMethod with wrong return type")
}
}
type pageWithBadMethod struct{}
func (p *pageWithBadMethod) BadMethod(needsString string) {
// This method expects string but we'll pass int
}
// Test callMethod error when method call fails
func TestParseContext_callMethod_error(t *testing.T) {
pc := &parseContext{args: make(argRegistry)}
pn := &PageNode{
Name: "test",
Value: reflect.ValueOf(&pageWithBadMethod{}),
}
method, _ := reflect.TypeOf(&pageWithBadMethod{}).MethodByName("BadMethod")
// Try to call with wrong type - should cause error
_, err := pc.callMethod(pn, &method, reflect.ValueOf(123)) // passing int instead of string
if err == nil {
t.Error("Expected error from callMethod with wrong argument type")
}
}
// Test types for Init method
type pageWithInit struct{}
func (p *pageWithInit) Init() error {
return nil
}
type pageWithInitError struct{}
func (p *pageWithInitError) Init() error {
return fmt.Errorf("init failed")
}
type pageWithInitPanic struct{}
func (p *pageWithInitPanic) Init() {
panic("init panic")
}
// Test callInitMethod
func TestParseContext_callInitMethod(t *testing.T) {
t.Run("successful init", func(t *testing.T) {
pc := &parseContext{args: make(argRegistry)}
pn := &PageNode{
Name: "test",
Value: reflect.ValueOf(&pageWithInit{}),
}
method, _ := reflect.TypeOf(&pageWithInit{}).MethodByName("Init")
err := pc.callInitMethod(pn, &method)
if err != nil {
t.Errorf("Unexpected error: %v", err)
}
})
t.Run("init returns error", func(t *testing.T) {
pc := &parseContext{args: make(argRegistry)}
pn := &PageNode{
Name: "test",
Value: reflect.ValueOf(&pageWithInitError{}),
}
method, _ := reflect.TypeOf(&pageWithInitError{}).MethodByName("Init")
err := pc.callInitMethod(pn, &method)
if err == nil {
t.Error("Expected error from Init method")
}
if !strings.Contains(err.Error(), "init failed") {
t.Errorf("Expected error to contain 'init failed', got: %v", err)
}
})
t.Run("callMethod fails", func(t *testing.T) {
// Create a type with Init method that requires missing arg
type pageWithInitNeedsArg struct{}
type initNeeder interface{ NeedThis() }
pc := &parseContext{args: make(argRegistry)}
pn := &PageNode{
Name: "test",
Value: reflect.ValueOf(&pageWithInitNeedsArg{}),
}
// Create a method that requires an unavailable argument
method := reflect.Method{
Name: "Init",
Type: reflect.TypeOf(func(*pageWithInitNeedsArg, initNeeder) error { return nil }),
Func: reflect.ValueOf(func(p *pageWithInitNeedsArg, n initNeeder) error {
return nil
}),
}
err := pc.callInitMethod(pn, &method)
if err == nil {
t.Error("Expected error when callMethod fails due to missing argument")
}
if !strings.Contains(err.Error(), "requires argument of type") {
t.Errorf("Expected error about missing argument, got: %v", err)
}
})
}
// Test for parseChildFields error path
type pageWithBadChild struct {
BadField struct{} `route:"/bad Bad"`
}
type pageWithNestedError struct {
Child *pageWithNilChild `route:"/child Child"`
}
type pageWithNilChild struct{}
func TestParseChildFields_error(t *testing.T) {
// This test will actually be covered by TestParsePageTree_childError below
// since parseChildFields is called during parsePageTree
}
// Test for processMethods error path
type pageWithBadInit struct{}
func (p *pageWithBadInit) Init(wrongParam int) error {
return nil
}
func TestProcessMethods_error(t *testing.T) {
t.Run("processMethod error", func(t *testing.T) {
pc := &parseContext{args: make(argRegistry)}
st := reflect.TypeOf(pageWithBadInit{})
pt := reflect.TypeOf(&pageWithBadInit{})
item := &PageNode{
Name: "test",
Value: reflect.ValueOf(&pageWithBadInit{}),
}
err := pc.processMethods(st, pt, item)
if err == nil {
t.Error("Expected error when Init method has wrong signature")
}
})
}
// Test callMethod edge cases
type pageWithPointerReceiver struct{}
func (p *pageWithPointerReceiver) PointerMethod() {}
type pageWithValueReceiverTest struct{}
func (p pageWithValueReceiverTest) ValueMethod() {}
type pageWithPageNodeArg struct{}
func (p *pageWithPageNodeArg) MethodWithPageNode(pn *PageNode) {}
type pageWithPageNodeValueArg struct{}
//nolint:gocritic // Testing value receiver for PageNode
func (p *pageWithPageNodeValueArg) MethodWithPageNodeValue(pn PageNode) {}
func TestCallMethod_receiverConversions(t *testing.T) {
t.Run("pointer receiver with value", func(t *testing.T) {
pc := &parseContext{args: make(argRegistry)}
// Create an addressable value
val := pageWithPointerReceiver{}
pn := &PageNode{
Name: "test",
Value: reflect.ValueOf(&val).Elem(), // addressable value
}
method, _ := reflect.TypeOf(&pageWithPointerReceiver{}).MethodByName("PointerMethod")
// Should convert value to pointer
_, err := pc.callMethod(pn, &method)
if err != nil {
t.Errorf("Unexpected error: %v", err)
}
})
t.Run("unaddressable value returns error", func(t *testing.T) {
pc := &parseContext{args: make(argRegistry)}
pn := &PageNode{
Name: "test",
Value: reflect.ValueOf(pageWithPointerReceiver{}), // unaddressable value
}
method, _ := reflect.TypeOf(&pageWithPointerReceiver{}).MethodByName("PointerMethod")
// This should now return an error instead of panicking
_, err := pc.callMethod(pn, &method)
if err == nil {
t.Error("Expected error for unaddressable value")
}
if !strings.Contains(err.Error(), "not addressable") {
t.Errorf("Expected error about not addressable, got: %v", err)
}
})
t.Run("PageNode argument", func(t *testing.T) {
pc := &parseContext{args: make(argRegistry)}
pn := &PageNode{
Name: "test",
Value: reflect.ValueOf(&pageWithPageNodeArg{}),
}
method, _ := reflect.TypeOf(&pageWithPageNodeArg{}).MethodByName("MethodWithPageNode")
// Should inject the PageNode
_, err := pc.callMethod(pn, &method)
if err != nil {
t.Errorf("Unexpected error: %v", err)
}
})
t.Run("PageNode value argument", func(t *testing.T) {
pc := &parseContext{args: make(argRegistry)}
pn := &PageNode{
Name: "test",
Value: reflect.ValueOf(&pageWithPageNodeValueArg{}),
}
method, _ := reflect.TypeOf(&pageWithPageNodeValueArg{}).MethodByName("MethodWithPageNodeValue")
// Should inject the PageNode value
_, err := pc.callMethod(pn, &method)
if err != nil {
t.Errorf("Unexpected error: %v", err)
}
})
}
// Test urlFor error case
func TestUrlFor_notFound(t *testing.T) {
type unknownPage struct{}
type knownPage struct{}
pc, err := parsePageTree("/", &knownPage{})
if err != nil {
t.Fatalf("parsePageTree failed: %v", err)
}
// Try to find URL for a type that doesn't exist in the tree
_, err = pc.urlFor(&unknownPage{})
if err == nil {
t.Error("Expected error when page not found")
}
if !strings.Contains(err.Error(), "no page node found") {
t.Errorf("Expected error to contain 'no page node found', got: %v", err)
}
}
// Test parsePageTree with child errors
func TestParsePageTree_childError(t *testing.T) {
type invalidChild struct {
StringField string `route:"/string String"`
}
type parentWithInvalidChild struct {
Child invalidChild `route:"/child Child"`
}
// This should fail because string fields can't be pages
_, err := parsePageTree("/", &parentWithInvalidChild{})
if err == nil {
t.Error("Expected error when child has invalid field")
}
}
// Test processMethods with method processing error
type pageWithInitThatNeedsArg struct{}
func (p *pageWithInitThatNeedsArg) Init(s string) error {
return nil
}
func TestProcessMethod_initWithMissingArg(t *testing.T) {
// Don't provide the string argument that Init needs
_, err := parsePageTree("/", &pageWithInitThatNeedsArg{})
if err == nil {
t.Error("Expected error when Init method requires unavailable argument")
return
}
if !strings.Contains(err.Error(), "requires argument of type string") {
t.Errorf("Expected error about missing string argument, got: %v", err)
}
}