From 0c8836df702f4d31942f7644c3f7394442720440 Mon Sep 17 00:00:00 2001 From: Martin Falk Date: Tue, 30 Jun 2026 11:32:03 +0200 Subject: [PATCH 1/3] DataFrameClustering: Inport onChange deprecation --- .../src/processors/dataframeclustering.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/misc/dataframeclustering/src/processors/dataframeclustering.cpp b/misc/dataframeclustering/src/processors/dataframeclustering.cpp index 87cd9ae2c..a44967fad 100644 --- a/misc/dataframeclustering/src/processors/dataframeclustering.cpp +++ b/misc/dataframeclustering/src/processors/dataframeclustering.cpp @@ -112,11 +112,13 @@ DataFrameClustering::DataFrameClustering() method_, [](const auto& p) { return p.getSelectedIdentifier() == "spectral"; }); method_.set("agglo"); - - dataFrame_.onChange([&]() { onDataFrameChange(); }); } void DataFrameClustering::process() { + if (dataFrame_.isChanged()) { + onDataFrameChange(); + } + pybind11::list cols; for (auto& p : columns_.getPropertiesByType()) { if (p->getVisible() && p->get()) { From 644fa472addc1a09cd50d836f2f9396ccd06d8c1 Mon Sep 17 00:00:00 2001 From: Martin Falk Date: Tue, 30 Jun 2026 11:32:08 +0200 Subject: [PATCH 2/3] VTK: Inport onChange deprecation --- .../vtk/processors/vtkgenericprocessor.h | 20 ++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/misc/vtk/include/inviwo/vtk/processors/vtkgenericprocessor.h b/misc/vtk/include/inviwo/vtk/processors/vtkgenericprocessor.h index bcb0f83d7..c031feaff 100644 --- a/misc/vtk/include/inviwo/vtk/processors/vtkgenericprocessor.h +++ b/misc/vtk/include/inviwo/vtk/processors/vtkgenericprocessor.h @@ -152,11 +152,6 @@ inline void updateFieldSelection(vtkDataObject::FieldAssociations assoc, vtkData void setupFieldSelection(Inport* inport, auto& wrapper) { if (auto* vtkinport = dynamic_cast(inport)) { - vtkinport->onChange([port = vtkinport, w = &wrapper]() { - if (port->isReady()) { - updateFieldSelection(w->fieldAssociation.get(), port->getData(), w->name); - } - }); wrapper.fieldAssociation.onChange([port = vtkinport, w = &wrapper]() { if (port->isReady()) { updateFieldSelection(w->fieldAssociation.get(), port->getData(), w->name); @@ -269,8 +264,19 @@ class VTKGenericProcessor : public Processor { virtual void process() override { bool ready = true; - util::for_each_in_tuple([&](auto& wrapper) { ready &= wrapper.set(*filter_); }, - traits_.properties); + util::for_each_in_tuple( + [&](auto& wrapper) { + if constexpr (std::is_base_of_v>) { + auto* inport = getInport(wrapper.inport); + if (const auto* vtkinport = dynamic_cast(inport); + vtkinport && vtkinport->isChanged() && vtkinport->isReady()) { + updateFieldSelection(wrapper.fieldAssociation.get(), vtkinport->getData(), + wrapper.name); + } + } + ready &= wrapper.set(*filter_); + }, + traits_.properties); if (!ready) return; From 662343ab783201b3a8e0c1b9903dcbe4953af16a Mon Sep 17 00:00:00 2001 From: Martin Falk Date: Wed, 1 Jul 2026 10:42:52 +0200 Subject: [PATCH 3/3] GHA: linux core dump *test* --- .github/workflows/modules.yml | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/.github/workflows/modules.yml b/.github/workflows/modules.yml index 79e426d95..b2b333d0f 100644 --- a/.github/workflows/modules.yml +++ b/.github/workflows/modules.yml @@ -67,7 +67,16 @@ jobs: targets: 'all' installer: 'inviwo-installer-linux' artifact: 'build/inviwo-v*.AppImage' - run: QT_QPA_PLATFORM=offscreen ./inviwo --logconsole --quit + run: | + ulimit -c + ulimit -c unlimited + QT_QPA_PLATFORM=offscreen ./inviwo --logconsole --quit + if [ -f ./core ]; then + echo "### core file in current dir" + gdb ./inviwo core --ex bt --ex quit + elif [ -f /var/crash/core ]; then + gdb ./inviwo /var/crash/core --ex bt --ex quit + fi # set triplets - system: 'windows'