From 0a3e9d8bacf4c81664e99dcfe1f6ba05b51cd50a Mon Sep 17 00:00:00 2001
From: Nicolas Mac Rouillon <nicolasmacr@gmail.com>
Date: Mon, 24 Aug 2026 09:31:14 -0300
Subject: [PATCH] [FIX] portal_holidays: restrict overtime hint to internal
 users in view - Add view inheriting hr_holidays.hr_leave_allocation_view_form
 setting   groups="base.group_user" on the div showing employee_overtime
 (element   added by hr_holidays_attendance) - Granting the field to
 group_portal_backend_holiday in Python is not   enough: during -u all the
 hr_holidays_attendance views are validated   before this module's override is
 loaded in the registry, so every full   upgrade logged 4 "Access Rights
 Inconsistency" warnings. View-level   groups live in the DB and hold during
 that window.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Change note: Los usuarios del portal con acceso a Ausencias dejan de ver el indicador "Extra Hours Available" (horas extra disponibles) en sus asignaciones; ese dato queda visible solo para usuarios internos. Con esto, las actualizaciones de versión dejan de registrar advertencias sobre esa pantalla.
---
 .../views/portal_holidays_views.xml            | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/portal_holidays/views/portal_holidays_views.xml b/portal_holidays/views/portal_holidays_views.xml
index eadd840e..323cad63 100644
--- a/portal_holidays/views/portal_holidays_views.xml
+++ b/portal_holidays/views/portal_holidays_views.xml
@@ -1,5 +1,23 @@
 <?xml version="1.0" encoding="utf-8"?>
 <odoo>
+    <!-- The overtime hint depends on employee_overtime, restricted to
+    base.group_user by hr_holidays_attendance. Granting the field to
+    group_portal_backend_holiday in Python is not enough: during -u all the
+    views of hr_holidays_attendance are validated before this module's
+    override is loaded in the registry, so the element must not be shown to
+    the portal group at the view level (DB) or every full upgrade logs an
+    Access Rights Inconsistency warning. -->
+    <record id="hr_leave_allocation_view_form_inherit_portal_holidays" model="ir.ui.view">
+        <field name="name">hr.leave.allocation.view.form.inherit.portal.holidays</field>
+        <field name="model">hr.leave.allocation</field>
+        <field name="inherit_id" ref="hr_holidays.hr_leave_allocation_view_form"/>
+        <field name="arch" type="xml">
+            <xpath expr="//div[field[@name='employee_overtime']]" position="attributes">
+                <attribute name="groups">base.group_user</attribute>
+            </xpath>
+        </field>
+    </record>
+
     <!-- Add My Time Off Action for portal holidays users -->
     <record id="hr_leave_action_my_portal_holidays" model="ir.actions.act_window">
         <field name="name">My Time Off</field>