Skip to content

Commit e0bb3ec

Browse files
Pass cancellation token
1 parent 5143c08 commit e0bb3ec

5 files changed

Lines changed: 9 additions & 9 deletions

File tree

CodeConverter/CSharp/ClashingMemberRenamer.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@ internal static class ClashingMemberRenamer
88
/// Renames symbols in a VB project so that they don't clash with rules for C# member names, attempting to rename the least public ones first.
99
/// See https://github.com/icsharpcode/CodeConverter/issues/420
1010
/// </summary>
11-
public static async Task<Project> RenameClashingSymbolsAsync(Project project)
11+
public static async Task<Project> RenameClashingSymbolsAsync(Project project, CancellationToken cancellationToken)
1212
{
13-
var compilation = await project.GetCompilationAsync();
13+
var compilation = await project.GetCompilationAsync(cancellationToken);
1414
var memberRenames = SymbolRenamer.GetNamespacesAndTypesInAssembly(project, compilation)
1515
.SelectMany(x => GetSymbolsWithNewNames(x, compilation));
16-
return await SymbolRenamer.PerformRenamesAsync(project, memberRenames.ToList());
16+
return await SymbolRenamer.PerformRenamesAsync(project, memberRenames.ToList(), cancellationToken);
1717
}
1818

1919
private static IEnumerable<(ISymbol Original, string NewName)> GetSymbolsWithNewNames(INamespaceOrTypeSymbol containerSymbol, Compilation compilation)

CodeConverter/CSharp/VBToCSProjectContentsConverter.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ public VBToCSProjectContentsConverter(ConversionOptions conversionOptions,
4040

4141
public async Task InitializeSourceAsync(Project project)
4242
{
43-
project = await ClashingMemberRenamer.RenameClashingSymbolsAsync(project);
43+
project = await ClashingMemberRenamer.RenameClashingSymbolsAsync(project, _cancellationToken);
4444
var cSharpCompilationOptions = CSharpCompiler.CreateCompilationOptions();
4545
_convertedCsProject = project.ToProjectFromAnyOptions(cSharpCompilationOptions, CSharpCompiler.ParseOptions);
4646
_csharpReferenceProject = project.CreateReferenceOnlyProjectFromAnyOptions(cSharpCompilationOptions, CSharpCompiler.ParseOptions);

CodeConverter/Common/SymbolRenamer.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public static string GetName(ISymbol m) {
2626
return m.Name;
2727
}
2828

29-
public static async Task<Project> PerformRenamesAsync(Project project, IEnumerable<(ISymbol Original, string NewName)> symbolsWithNewNames)
29+
public static async Task<Project> PerformRenamesAsync(Project project, IEnumerable<(ISymbol Original, string NewName)> symbolsWithNewNames, CancellationToken cancellationToken)
3030
{
3131
var solution = project.Solution;
3232
foreach (var (originalSymbol, newName) in symbolsWithNewNames.OrderByDescending(s => s.Original.DeclaringSyntaxReferences.Select(x => x.Span.End).Max())) {

CodeConverter/VB/CSToVBProjectContentsConverter.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public CSToVBProjectContentsConverter(ConversionOptions conversionOptions, IProg
4545
public async Task InitializeSourceAsync(Project project)
4646
{
4747
// TODO: Don't throw away solution-wide effects - write them to referencing files, and use in conversion of any other projects being converted at the same time.
48-
project = await ClashingMemberRenamer.RenameClashingSymbolsAsync(project);
48+
project = await ClashingMemberRenamer.RenameClashingSymbolsAsync(project, _cancellationToken);
4949
_convertedVbProject = project.ToProjectFromAnyOptions(_vbCompilationOptions, _vbParseOptions);
5050
_vbReferenceProject = project.CreateReferenceOnlyProjectFromAnyOptions(_vbCompilationOptions, _vbParseOptions);
5151
_vbViewOfCsSymbols = (VisualBasicCompilation)await _vbReferenceProject.GetCompilationAsync(_cancellationToken);

CodeConverter/VB/ClashingMemberRenamer.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,12 @@ internal static class ClashingMemberRenamer
1010
/// Cases in different named scopes should be dealt with by <seealso cref="DocumentExtensions.ExpandAsync"/>.
1111
/// For names scoped within a type member, see <seealso cref="SemanticModelSymbolSetExtensions.GetCsLocalSymbolsPerScope"/>.
1212
/// </remarks>
13-
public static async Task<Project> RenameClashingSymbolsAsync(Project project)
13+
public static async Task<Project> RenameClashingSymbolsAsync(Project project, CancellationToken cancellationToken)
1414
{
15-
var compilation = await project.GetCompilationAsync();
15+
var compilation = await project.GetCompilationAsync(cancellationToken);
1616
var memberRenames = SymbolRenamer.GetNamespacesAndTypesInAssembly(project, compilation)
1717
.SelectMany(x => GetSymbolsWithNewNames(x, compilation));
18-
return await SymbolRenamer.PerformRenamesAsync(project, memberRenames.ToList());
18+
return await SymbolRenamer.PerformRenamesAsync(project, memberRenames.ToList(), cancellationToken);
1919
}
2020

2121
private static IEnumerable<(ISymbol Original, string NewName)> GetSymbolsWithNewNames(INamespaceOrTypeSymbol containerSymbol, Compilation compilation)

0 commit comments

Comments
 (0)