Wrap all cases for case insensitive strings

Author: GrahamTheCoder

CodeConverter/CSharp/MethodBodyExecutableStatementVisitor.cs

@@ -641,6 +641,8 @@ public override async Task<SyntaxList<StatementSyntax>> VisitGoToStatement(VBSyn
         public override async Task<SyntaxList<StatementSyntax>> VisitSelectBlock(VBSyntax.SelectBlockSyntax node)
         {
             var vbExpr = node.SelectStatement.Expression;
+            var wrapAllCases = CommonConversions.VisualBasicEqualityComparison.OptionCompareTextCaseInsensitive &&
+                _semanticModel.GetTypeInfo(vbExpr).ConvertedType?.SpecialType == SpecialType.System_String;
             var (csExpr, stmts, csExprWithSourceMapping) = await GetExpressionWithoutSideEffectsAsync(vbExpr, "switchExpr");
             var usedConstantValues = new HashSet<object>();
             var sections = new List<SwitchSectionSyntax>();
@@ -654,7 +656,7 @@ public override async Task<SyntaxList<StatementSyntax>> VisitSelectBlock(VBSynta
                         var correctTypeExpressionSyntax = CommonConversions.TypeConversionAnalyzer.AddExplicitConversion(s.Value, originalExpressionSyntax, typeConversionKind, true, true);
                         var constantValue = _semanticModel.GetConstantValue(s.Value);
                         var notAlreadyUsed = !constantValue.HasValue || usedConstantValues.Add(constantValue.Value);
-                        var caseSwitchLabelSyntax = correctTypeExpressionSyntax.IsConst && notAlreadyUsed
+                        var caseSwitchLabelSyntax = !wrapAllCases && correctTypeExpressionSyntax.IsConst && notAlreadyUsed
                             ? (SwitchLabelSyntax)SyntaxFactory.CaseSwitchLabel(correctTypeExpressionSyntax.Expr)
                             : WrapInCasePatternSwitchLabelSyntax(node, correctTypeExpressionSyntax.Expr);
                         labels.Add(caseSwitchLabelSyntax);

Tests/CSharp/StatementTests/StatementTests.cs

@@ -1761,6 +1761,44 @@ public int Add(int x)
 }");
         }
 
+        [Fact]
+        public async Task Issue579SelectCaseWithCaseInsensitiveTextCompareAsync()
+        {
+            await TestConversionVisualBasicToCSharpAsync(@"
+Option Compare Text
+
+Class Issue579SelectCaseWithCaseInsensitiveTextCompare
+Private Function Test(astr_Temp As String) As Boolean
+    Select Case astr_Temp
+        Case ""Test""
+            Return True
+        Case Else
+            Return False
+    End Select
+End Function
+End Class", @"
+internal partial class Issue579SelectCaseWithCaseInsensitiveTextCompare
+{
+    private bool Test(string astr_Temp)
+    {
+        switch (astr_Temp)
+        {
+            case var @case when @case == ""Test"":
+                {
+                    return true;
+                }
+
+            default:
+                {
+                    return false;
+                }
+        }
+    }
+}
+1 target compilation errors:
+CS0825: The contextual keyword 'var' may only appear within a local variable declaration or in script code");
+        }
+
         [Fact]
         public async Task TryCatchAsync()
         {