Skip to content

Commit d42b8d7

Browse files
Try to let vsix override the langversion with one msbuild 17 can handle
1 parent 0d6a4d4 commit d42b8d7

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

.github/workflows/dotnet.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ jobs:
3535
- name: Add msbuild to PATH
3636
uses: microsoft/setup-msbuild@v2
3737
with:
38-
vs-version: '[18.0,)'
38+
vs-version: '[17.0,)'
3939

4040
- name: Dotnet deterministic Build
4141
run: dotnet build DotNetBuildable.slnf /p:Platform=$env:BuildPlatform /p:Configuration=$env:BuildTarget /p:ContinuousIntegrationBuild=true

Directory.Build.props

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,12 @@
77
<WarningsNotAsErrors>$(WarningsNotAsErrors);NU1605;NU1701;NU1901;NU1902;NU1903;NU1904;NU1510;NU1903</WarningsNotAsErrors>
88
<WarningLevel>4</WarningLevel>
99
<EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
10-
<LangVersion>14.0</LangVersion>
10+
<LangVersion Condition="'$(LangVersion)' == ''">14.0</LangVersion>
1111
<AssemblyVersion>10.0.0.0</AssemblyVersion>
1212
<FileVersion>10.0.0.0</FileVersion>
1313
<Version>10.0.0</Version>
1414
<Authors>ICSharpCode</Authors>
1515
<Copyright>Copyright (c) 2017-2023 AlphaSierraPapa for the CodeConverter team</Copyright>
1616
<Company>ICSharpCode</Company>
1717
</PropertyGroup>
18-
</Project>
18+
</Project>

Vsix/Vsix.csproj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<?xml version="1.0" encoding="utf-8"?>
1+
<?xml version="1.0" encoding="utf-8"?>
22
<Project ToolsVersion="15.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
33
<PropertyGroup>
44
<MinimumVisualStudioVersion>16.0</MinimumVisualStudioVersion>
@@ -24,7 +24,7 @@
2424
<SignAssembly>false</SignAssembly>
2525
<DeployExtension Condition="'$(BuildingInsideVisualStudio)' != 'true'">False</DeployExtension>
2626
<RuntimeIdentifiers>win</RuntimeIdentifiers>
27-
<LangVersion>9.0</LangVersion>
27+
<LangVersion>12.0</LangVersion>
2828
</PropertyGroup>
2929
<Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />
3030
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
@@ -162,4 +162,4 @@
162162
<Target Name="AfterBuild">
163163
</Target>
164164
-->
165-
</Project>
165+
</Project>

0 commit comments

Comments
 (0)