Make readonly

Author: GrahamTheCoder

CodeConverter/CSharp/ExpressionNodeVisitor.cs

@@ -40,7 +40,7 @@ internal class ExpressionNodeVisitor : VBasic.VisualBasicSyntaxVisitor<Task<CSha
         private readonly Lazy<IDictionary<ITypeSymbol, string>> _convertMethodsLookupByReturnType;
         private readonly Compilation _csCompilation;
         private readonly LambdaConverter _lambdaConverter;
-        private INamedTypeSymbol _vbBooleanTypeSymbol;
+        private readonly INamedTypeSymbol _vbBooleanTypeSymbol;
 
         public ExpressionNodeVisitor(SemanticModel semanticModel,
             VisualBasicEqualityComparison visualBasicEqualityComparison,

CodeConverter/CSharp/MethodBodyExecutableStatementVisitor.cs

@@ -31,7 +31,7 @@ internal class MethodBodyExecutableStatementVisitor : VBasic.VisualBasicSyntaxVi
         private readonly MethodsWithHandles _methodsWithHandles;
         private readonly HashSet<string> _generatedNames = new HashSet<string>();
         private readonly HashSet<VBSyntax.StatementSyntax> _redundantSourceStatements = new HashSet<VBSyntax.StatementSyntax>();
-        private INamedTypeSymbol _vbBooleanTypeSymbol;
+        private readonly INamedTypeSymbol _vbBooleanTypeSymbol;
         private readonly HashSet<ILocalSymbol> _localsToInlineInLoop;
 
         public bool IsIterator { get; set; }

CodeConverter/CSharp/MethodWithHandles.cs

@@ -13,7 +13,7 @@ namespace ICSharpCode.CodeConverter.CSharp
 {
     internal class MethodWithHandles
     {
-        private IdentifierNameSyntax _methodId;
+        private readonly IdentifierNameSyntax _methodId;
         private readonly SyntaxGenerator _csSyntaxGenerator;
 
         public SyntaxToken MethodCSharpId { get; }

CodeConverter/CSharp/MethodsWithHandles.cs

@@ -12,8 +12,8 @@ namespace ICSharpCode.CodeConverter.CSharp
     /// </summary>
     internal class MethodsWithHandles
     {
-        private List<MethodWithHandles> _methodWithHandleses;
-        private ILookup<string, MethodWithHandles> _handledMethodsFromPropertyWithEventName;
+        private readonly List<MethodWithHandles> _methodWithHandleses;
+        private readonly ILookup<string, MethodWithHandles> _handledMethodsFromPropertyWithEventName;
 
 
         public MethodsWithHandles(List<MethodWithHandles> methodWithHandleses, ILookup<string, MethodWithHandles> handledMethodsFromPropertyWithEventName)

CodeConverter/CSharp/ProjectExtensions.cs

@@ -8,7 +8,7 @@ namespace ICSharpCode.CodeConverter.CSharp
 {
     internal static class ProjectExtensions
     {
-        private static char[] DirSeparators = new[] { Path.DirectorySeparatorChar, Path.AltDirectorySeparatorChar };
+        private static readonly char[] DirSeparators = new[] { Path.DirectorySeparatorChar, Path.AltDirectorySeparatorChar };
 
         public static Project CreateReferenceOnlyProjectFromAnyOptions(this Project project, CompilationOptions baseOptions, ParseOptions parseOptions)
         {

CodeConverter/CSharp/QueryConverter.cs

@@ -19,7 +19,7 @@ namespace ICSharpCode.CodeConverter.CSharp
     internal class QueryConverter
     {
         private readonly CommentConvertingVisitorWrapper _triviaConvertingVisitor;
-        private SemanticModel _semanticModel;
+        private readonly SemanticModel _semanticModel;
 
         public QueryConverter(CommonConversions commonConversions, SemanticModel semanticModel, CommentConvertingVisitorWrapper triviaConvertingExpressionVisitor)
         {

CodeConverter/Shared/DefaultReferences.cs

@@ -35,7 +35,7 @@ public static class DefaultReferences
             new[] { Assembly.Load("System.Runtime, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a") }
             ).ToArray();
 
-        private static Dictionary<string, (string Location, string[] ReferenceNames)> _assemblyInfoCache = new Dictionary<string, (string Location, string[] ReferenceNames)>();
+        private static readonly Dictionary<string, (string Location, string[] ReferenceNames)> _assemblyInfoCache = new Dictionary<string, (string Location, string[] ReferenceNames)>();
 
         public static IReadOnlyCollection<PortableExecutableReference> NetStandard2 { get; } =
             With(Enumerable.Empty<Assembly>()).ToArray();

CodeConverter/Util/FromRoslyn/SpecializedCollections.cs

@@ -517,7 +517,7 @@ private static partial class Singleton
         {
             internal sealed class Collection<T> : ICollection<T>, IReadOnlyCollection<T>
             {
-                private T _loneValue;
+                private readonly T _loneValue;
 
                 public Collection(T value)
                 {
@@ -569,7 +569,7 @@ IEnumerator IEnumerable.GetEnumerator()
             }
             internal class Enumerator<T> : IEnumerator<T>
             {
-                private T _loneValue;
+                private readonly T _loneValue;
                 private bool _moveNextCalled;
 
                 public Enumerator(T value)

CodeConverter/VB/CSharpHelperMethodDefinition.CSharpHelperMethodDefinition.cs

@@ -28,7 +28,7 @@ Return value
     Throw e
 End Function";
 
-        private static ICompiler _compiler = new VisualBasicCompiler();
+        private static readonly ICompiler _compiler = new VisualBasicCompiler();
 
         public bool AddThrowMethod { get; set; }
         public bool AddInlineAssignMethod { get; set; }

CommandLine/CodeConv.NetFramework/CodeConvProgram.NetFramework.cs

@@ -2,6 +2,6 @@ namespace ICSharpCode.CodeConverter.CommandLine
 {
     public partial class CodeConvProgram
     {
-        private static bool _runningInNetCore = false;
+        private static readonly bool _runningInNetCore = false;
     }
 }