Deal with array type symbols - fixes #559

Author: GrahamTheCoder

.editorconfig

@@ -146,3 +146,6 @@ dotnet_style_parentheses_in_arithmetic_binary_operators = always_for_clarity:non
 
 # RCS1123: Add parentheses according to operator precedence.
 dotnet_diagnostic.RCS1123.severity = none
+
+# Default severity for analyzer diagnostics with category 'Performance' - turn this up to warn when looking for performance issues
+dotnet_analyzer_diagnostic.category-Performance.severity = suggestion

CHANGELOG.md

@@ -9,7 +9,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 
 
 ### VB -> C#
-
+* Improve multi-declaration field conversion for arrrays - [#559](https://github.com/icsharpcode/CodeConverter/issues/559)
 
 ### C# -> VB
 

CodeConverter/Util/TypeExtensions.cs

@@ -66,6 +66,9 @@ public static IEnumerable<INamedTypeSymbol> GetAllBaseClassesAndInterfaces(this
         /// <param name="symbol">Symbol.</param>
         public static string GetFullMetadataName(this ITypeSymbol symbol)
         {
+            if (symbol is IArrayTypeSymbol ats) {
+                return GetFullMetadataName(ats.ElementType) + "[" + Enumerable.Repeat(',', ats.Rank - 1) + "]";
+            }
             //This is for comaptibility with NR5 reflection name in case of generic types like T1, T2...
             var namedTypeSymbol = symbol as INamedTypeSymbol;
             return namedTypeSymbol != null ? GetFullMetadataName(namedTypeSymbol) : symbol.MetadataName;

Tests/CSharp/MemberTests.cs

@@ -24,6 +24,21 @@ internal partial class TestClass
 }");
         }
 
+        [Fact]
+        public async Task TestMultiArrayFieldAsync()
+        {
+            await TestConversionVisualBasicToCSharpAsync(
+@"Class TestClass
+    Dim Parts(), Taxes(), Deposits()(), Prepaid()(), FromDate, ToDate As String
+End Class", @"
+internal partial class TestClass
+{
+    private string[] Parts, Taxes;
+    private string[][] Deposits, Prepaid;
+    private string FromDate, ToDate;
+}");
+        }
+
         [Fact]
         public async Task TestConstantFieldInModuleAsync()
         {