GetRefConversion: for const fields and locals always return RefConversion.PreAssigment

Timur Kelman · Timur Kelman · commit a265518b683a · 2024-07-22T16:07:36.000+02:00
diff --git a/CodeConverter/CSharp/ExpressionNodeVisitor.cs b/CodeConverter/CSharp/ExpressionNodeVisitor.cs
@@ -1836,6 +1836,9 @@ RefConversion GetRefConversion(VBSyntax.ExpressionSyntax expression)
             if (symbolInfo is IPropertySymbol propertySymbol) {
                 return propertySymbol.IsReadOnly ? RefConversion.PreAssigment : RefConversion.PreAndPostAssignment;
             }
+            else if (symbolInfo is IFieldSymbol { IsConst: true } || symbolInfo is ILocalSymbol { IsConst: true }) {
+                return RefConversion.PreAssigment;
+            }
 
             if (DeclaredInUsing(symbolInfo)) return RefConversion.PreAssigment;
 

Original file line number	Diff line number	Diff line change
`@@ -1836,6 +1836,9 @@ RefConversion GetRefConversion(VBSyntax.ExpressionSyntax expression)`
`1836`	`1836`	`if (symbolInfo is IPropertySymbol propertySymbol) {`
`1837`	`1837`	`return propertySymbol.IsReadOnly ? RefConversion.PreAssigment : RefConversion.PreAndPostAssignment;`
`1838`	`1838`	`}`
	`1839`	`+ else if (symbolInfo is IFieldSymbol { IsConst: true } \|\| symbolInfo is ILocalSymbol { IsConst: true }) {`
	`1840`	`+ return RefConversion.PreAssigment;`
	`1841`	`+ }`
`1839`	`1842`
`1840`	`1843`	`if (DeclaredInUsing(symbolInfo)) return RefConversion.PreAssigment;`
`1841`	`1844`