Skip to content

Commit 9a71c5a

Browse files
We don't want to prune assemblies (NU1510). And for now the tests pass in spite of RS1039, so we'll try to get a release out before addressing that
1 parent ebc32a9 commit 9a71c5a

2 files changed

Lines changed: 2 additions & 5 deletions

File tree

CodeConverter/CodeConverter.csproj

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,6 @@
1818
<ImplicitUsings>enable</ImplicitUsings>
1919
<AnalysisMode>Recommended</AnalysisMode>
2020
<LangVersion>latest</LangVersion>
21-
<!-- TODO Put a breakpoint and check if this is really correct, if so quite a few fixes are needed -->
22-
<WarningsNotAsErrors>RS1039</WarningsNotAsErrors>
23-
2421
</PropertyGroup>
2522

2623
<PropertyGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">

Directory.Build.props

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22
<PropertyGroup>
33
<AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath>
44
<AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>
5-
<NoWarn>$(NoWarn);1998;NU5100</NoWarn>
5+
<NoWarn>$(NoWarn);1998;NU1510;NU5100</NoWarn>
66
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
7-
<WarningsNotAsErrors>$(WarningsNotAsErrors);NU1605;NU1701;NU1901;NU1902;NU1903;NU1904;NU1510;NU1903</WarningsNotAsErrors>
7+
<WarningsNotAsErrors>$(WarningsNotAsErrors);NU1605;NU1701;NU1901;NU1902;NU1903;NU1904;NU1510;NU1903;RS1039</WarningsNotAsErrors>
88
<WarningLevel>4</WarningLevel>
99
<EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
1010
<LangVersion>10.0</LangVersion>

0 commit comments

Comments
 (0)