Merge remote-tracking branch 'origin/master' into fix/MissingByRefArgument/1

GrahamTheCoder · GrahamTheCoder · commit 96bfdb72cb43 · 2024-07-22T23:44:35.000+01:00
# Conflicts:
#	Tests/CSharp/MemberTests/MemberTests.cs
diff --git a/CodeConverter/CSharp/ExpressionNodeVisitor.cs b/CodeConverter/CSharp/ExpressionNodeVisitor.cs
@@ -1882,6 +1882,9 @@ RefConversion GetRefConversion(VBSyntax.ExpressionSyntax expression)
             if (symbolInfo is IPropertySymbol propertySymbol) {
                 return propertySymbol.IsReadOnly ? RefConversion.PreAssigment : RefConversion.PreAndPostAssignment;
             }
+            else if (symbolInfo is IFieldSymbol { IsConst: true } or ILocalSymbol { IsConst: true }) {
+                return RefConversion.PreAssigment;
+            }
 
             if (DeclaredInUsing(symbolInfo)) return RefConversion.PreAssigment;
 

Original file line number	Diff line number	Diff line change
`@@ -1882,6 +1882,9 @@ RefConversion GetRefConversion(VBSyntax.ExpressionSyntax expression)`
`1882`	`1882`	`if (symbolInfo is IPropertySymbol propertySymbol) {`
`1883`	`1883`	`return propertySymbol.IsReadOnly ? RefConversion.PreAssigment : RefConversion.PreAndPostAssignment;`
`1884`	`1884`	`}`
	`1885`	`+ else if (symbolInfo is IFieldSymbol { IsConst: true } or ILocalSymbol { IsConst: true }) {`
	`1886`	`+ return RefConversion.PreAssigment;`
	`1887`	`+ }`
`1885`	`1888`
`1886`	`1889`	`if (DeclaredInUsing(symbolInfo)) return RefConversion.PreAssigment;`
`1887`	`1890`