Accept changes which seem fine and likely just caused by evolving libraries

Author: GrahamTheCoder

Tests/CSharp/ExpressionTests/ExpressionTests.cs

@@ -319,7 +319,7 @@ public void Rounding()
     }
 }
 1 target compilation errors:
-CS1503: Argument 1: cannot convert from 'object' to 'double'");
+CS1503: Argument 1: cannot convert from 'object' to 'decimal'");
     }
 
     [Fact]

Tests/CSharp/ExpressionTests/LinqExpressionTests.cs

@@ -388,7 +388,8 @@ Public Shared Sub X(objs As List(Of Object))
         Dim MaxObj As Integer = Aggregate o In objs Into Max(o.GetHashCode())
         Dim CountWhereObj As Integer = Aggregate o In objs Where o.GetHashCode() > 3 Into Count()
     End Sub
-End Class", @"using System.Collections.Generic;
+End Class", @"using System;
+using System.Collections.Generic;
 using System.Linq;
 
 public partial class VisualBasicClass
@@ -611,7 +612,8 @@ Sub Foo()
         Dim xs As New List(Of String)
         Dim y = From x In xs Group By x.Length, x.Count() Into Group
     End Sub
-End Class", @"using System.Collections.Generic;
+End Class", @"using System;
+using System.Collections.Generic;
 using System.Linq;
 
 public partial class Class1

Tests/CSharp/ExpressionTests/XmlExpressionTests.cs

@@ -116,22 +116,22 @@ private void TestMethod()
     {
         var catalog = new XDocument(
 new XElement(""Catalog"",
-new XElement(""Book"", new XAttribute(""id"", ""bk101""),
-new XElement(""Author"", ""Garghentini, Davide""),
-new XElement(""Title"", ""XML Developer's Guide""),
-new XElement(""Price"", ""44.95""),
-new XElement(""Description"", @""
+    new XElement(""Book"", new XAttribute(""id"", ""bk101""),
+        new XElement(""Author"", ""Garghentini, Davide""),
+        new XElement(""Title"", ""XML Developer's Guide""),
+        new XElement(""Price"", ""44.95""),
+        new XElement(""Description"", @""
           An in-depth look at creating applications
           with "", new XElement(""technology"", ""XML""), @"". For
           "", new XElement(""audience"", ""beginners""), @"" or
           "", new XElement(""audience"", ""advanced""), @"" developers.
         "")
-),
-new XElement(""Book"", new XAttribute(""id"", ""bk331""),
-new XElement(""Author"", ""Spencer, Phil""),
-new XElement(""Title"", ""Developing Applications with Visual Basic .NET""),
-new XElement(""Price"", ""45.95""),
-new XElement(""Description"", @""
+    ),
+    new XElement(""Book"", new XAttribute(""id"", ""bk331""),
+        new XElement(""Author"", ""Spencer, Phil""),
+        new XElement(""Title"", ""Developing Applications with Visual Basic .NET""),
+        new XElement(""Price"", ""45.95""),
+        new XElement(""Description"", @""
           Get the expert insights, practical code samples,
           and best practices you need
           to advance your expertise with "", new XElement(""technology"", @""Visual
@@ -140,23 +140,21 @@ and best practices you need
           based on professional,
           pragmatic guidance by today's top "", new XElement(""audience"", ""developers""), @"".
         "")
-)
+    )
 )
 
 );
         var htmlOutput = new XElement(""html"",
-
                   new XElement(""body"", from book in catalog.Elements(""Catalog"").Elements(""Book"")
                                        select new XElement(""div"",
-                 new XElement(""h1"", book.Elements(""Title"").Value),
-                 new XElement(""h3"", ""By "" + book.Elements(""Author"").Value),
-                 new XElement(""h3"", ""Price = "" + book.Elements(""Price"").Value),
-
+                                                  new XElement(""h1"", book.Elements(""Title"").Value),
+                                                  new XElement(""h3"", ""By "" + book.Elements(""Author"").Value),
+                                                  new XElement(""h3"", ""Price = "" + book.Elements(""Price"").Value),
 
                                                   new XElement(""h2"", ""Description""), TransformDescription((string)book.Elements(""Description"").ElementAtOrDefault(0)), new XElement(""hr"")
-                 )
-                    )
-                );
+                                              )
+              )
+          );
     }
 
     public string TransformDescription(string s)

Tests/CSharp/MemberTests/MemberTests.cs

@@ -786,8 +786,7 @@ public async Task FieldWithInstanceOperationOfDifferingTypeAsync()
     {
         await TestConversionVisualBasicToCSharpAsync(@"Public Class DoesNotNeedConstructor
     Private ReadOnly ClassVariable1 As New ParallelOptions With {.MaxDegreeOfParallelism = 5}
-End Class", @"using System.Threading.Tasks;
-
+End Class", @"
 public partial class DoesNotNeedConstructor
 {
     private readonly ParallelOptions ClassVariable1 = new ParallelOptions() { MaxDegreeOfParallelism = 5 };
@@ -1154,7 +1153,7 @@ await TestConversionVisualBasicToCSharpAsync(
             @"<DllImport(""kernel32.dll"", SetLastError:=True)>
 Private Shared Function OpenProcess(ByVal dwDesiredAccess As AccessMask, ByVal bInheritHandle As Boolean, ByVal dwProcessId As UInteger) As IntPtr
 End Function", @"[DllImport(""kernel32.dll"", SetLastError = true)]
-private static extern IntPtr OpenProcess(AccessMask dwDesiredAccess, bool bInheritHandle, uint dwProcessId);
+private static extern nint OpenProcess(AccessMask dwDesiredAccess, bool bInheritHandle, uint dwProcessId);
 
 1 source compilation errors:
 BC30002: Type 'AccessMask' is not defined.
@@ -1529,7 +1528,7 @@ private void OptionalByRefWithDefault([Optional][DefaultParameterValue(""a"")] r
 BC30455: Argument not specified for parameter 'str2' of 'Private Sub OptionalByRefNoDefault(ByRef str2 As String)'.
 BC30455: Argument not specified for parameter 'str3' of 'Private Sub OptionalByRefWithDefault(ByRef str3 As String)'.
 1 target compilation errors:
-CS7036: There is no argument given that corresponds to the required formal parameter 'str1' of 'MissingByRefArgumentWithNoExplicitDefaultValue.ByRefNoDefault(ref string)'
+CS7036: There is no argument given that corresponds to the required parameter 'str1' of 'MissingByRefArgumentWithNoExplicitDefaultValue.ByRefNoDefault(ref string)'
 ");
     }
 }

Tests/CSharp/MissingSemanticModelInfo/ExpressionTests.cs

@@ -103,7 +103,8 @@ Sub Foo()
 
         Next
     End Sub
-End Class", @"
+End Class", @"using System.Linq;
+
 public partial class Class1
 {
     public void Foo()

Tests/CSharp/NamespaceLevelTests.cs

@@ -427,7 +427,7 @@ internal partial class test : IComparable
 1 source compilation errors:
 BC30149: Class 'test' must implement 'Function CompareTo(obj As Object) As Integer' for interface 'IComparable'.
 1 target compilation errors:
-CS0535: 'test' does not implement interface member 'IComparable.CompareTo(object)'");
+CS0535: 'test' does not implement interface member 'IComparable.CompareTo(object?)'");
     }
 
     [Fact]
@@ -444,7 +444,7 @@ internal partial class ClassImplementsInterface2 : IComparable
 1 source compilation errors:
 BC30149: Class 'ClassImplementsInterface2' must implement 'Function CompareTo(obj As Object) As Integer' for interface 'IComparable'.
 1 target compilation errors:
-CS0535: 'ClassImplementsInterface2' does not implement interface member 'IComparable.CompareTo(object)'");
+CS0535: 'ClassImplementsInterface2' does not implement interface member 'IComparable.CompareTo(object?)'");
     }
 
     [Fact]

Tests/CSharp/StatementTests/MethodStatementTests.cs

@@ -291,7 +291,7 @@ internal partial class TestClass
     private void TestMethod()
     {
         string b;
-        b = new string(""test"".ToCharArray());
+        b = new string(""test"");
     }
 }");
     }
@@ -325,7 +325,7 @@ internal partial class TestClass
 {
     private void TestMethod()
     {
-        string b = new string(""test"".ToCharArray());
+        string b = new string(""test"");
     }
 }");
     }
@@ -342,7 +342,7 @@ internal partial class TestClass
 {
     private void TestMethod()
     {
-        string b = new string(""test"".ToCharArray());
+        string b = new string(""test"");
     }
 }");
     }
@@ -608,7 +608,7 @@ public static void Main()
         {
             y._x = 1;
             Console.Write(y._x);
-            y = (TestWithForEachClass)null;
+            y = null;
         }
     }
 }

Tests/CSharp/TriviaTests.cs

@@ -377,8 +377,7 @@ End Sub
     Private ReadOnly ClassVariable1 As New ParallelOptions With {.MaxDegreeOfParallelism = x}
 #End Region
 End Class
-", @"using System.Threading.Tasks;
-
+", @"
 public partial class ConversionTest8
 {
     private int x = 5;

Tests/VB/MemberTests.cs

@@ -968,11 +968,10 @@ await TestConversionCSharpToVisualBasicAsync(
 Private Shared Function OpenProcess(dwDesiredAccess As AccessMask, bInheritHandle As Boolean, dwProcessId As UInteger) As IntPtr
 End Function
 
-4 source compilation errors:
+3 source compilation errors:
 CS0246: The type or namespace name 'AccessMask' could not be found (are you missing a using directive or an assembly reference?)
 CS0246: The type or namespace name 'DllImportAttribute' could not be found (are you missing a using directive or an assembly reference?)
 CS0246: The type or namespace name 'DllImport' could not be found (are you missing a using directive or an assembly reference?)
-CS0246: The type or namespace name 'SetLastError' could not be found (are you missing a using directive or an assembly reference?)
 1 target compilation errors:
 BC30002: Type 'AccessMask' is not defined.");
     }
@@ -1308,12 +1307,12 @@ End Class
 
 15 source compilation errors:
 CS1002: ; expected
-CS0535: 'TestClass' does not implement interface member 'IList.Add(object)'
-CS0535: 'TestClass' does not implement interface member 'IList.Contains(object)'
+CS0535: 'TestClass' does not implement interface member 'IList.Add(object?)'
+CS0535: 'TestClass' does not implement interface member 'IList.Contains(object?)'
 CS0535: 'TestClass' does not implement interface member 'IList.Clear()'
-CS0535: 'TestClass' does not implement interface member 'IList.IndexOf(object)'
-CS0535: 'TestClass' does not implement interface member 'IList.Insert(int, object)'
-CS0535: 'TestClass' does not implement interface member 'IList.Remove(object)'
+CS0535: 'TestClass' does not implement interface member 'IList.IndexOf(object?)'
+CS0535: 'TestClass' does not implement interface member 'IList.Insert(int, object?)'
+CS0535: 'TestClass' does not implement interface member 'IList.Remove(object?)'
 CS0535: 'TestClass' does not implement interface member 'IList.RemoveAt(int)'
 CS0535: 'TestClass' does not implement interface member 'IList.IsReadOnly'
 CS0535: 'TestClass' does not implement interface member 'IList.IsFixedSize'

Tests/VB/NamespaceLevelTests.cs

@@ -443,7 +443,7 @@ Implements IComparable
 End Class
 
 1 source compilation errors:
-CS0535: 'test' does not implement interface member 'IComparable.CompareTo(object)'
+CS0535: 'test' does not implement interface member 'IComparable.CompareTo(object?)'
 1 target compilation errors:
 BC30149: Class 'test' must implement 'Function CompareTo(obj As Object) As Integer' for interface 'IComparable'.");
     }