Don't use private keyword when already declared private

Author: GrahamTheCoder

CodeConverter/CSharp/DeclarationNodeVisitor.cs

@@ -685,7 +685,8 @@ public override async Task<CSharpSyntaxNode> VisitPropertyStatement(VBSyntax.Pro
             var convertibleModifiers = node.Modifiers.Where(m => !m.IsKind(VBasic.SyntaxKind.ReadOnlyKeyword, VBasic.SyntaxKind.WriteOnlyKeyword, VBasic.SyntaxKind.DefaultKeyword));
             var modifiers = CommonConversions.ConvertModifiers(node, convertibleModifiers.ToList(), GetMemberContext(node));
             var isIndexer = CommonConversions.IsDefaultIndexer(node);
-            var accessedThroughMyClass = IsAccessedThroughMyClass(node, node.Identifier, ModelExtensions.GetDeclaredSymbol(_semanticModel, node));
+            var nodeSymbol = ModelExtensions.GetDeclaredSymbol(_semanticModel, node);
+            var accessedThroughMyClass = IsAccessedThroughMyClass(node, node.Identifier, nodeSymbol);
             bool hasImplementation = !node.Modifiers.Any(m => m.IsKind(VBasic.SyntaxKind.MustOverrideKeyword)) && node.GetAncestor<VBSyntax.InterfaceBlockSyntax>() == null;
 
             var initializer = (EqualsValueClauseSyntax) await node.Initializer.AcceptAsync(_triviaConvertingExpressionVisitor);
@@ -730,7 +731,7 @@ public override async Task<CSharpSyntaxNode> VisitPropertyStatement(VBSyntax.Pro
                         )
                     ));
             } else {
-                accessors = ConvertSimpleAccessors(isWriteOnly, isReadonly, hasImplementation);
+                accessors = ConvertSimpleAccessors(isWriteOnly, isReadonly, hasImplementation, nodeSymbol.DeclaredAccessibility);
             }
 
 
@@ -806,19 +807,19 @@ private string AddRealPropertyDelegatingToMyClassVersion(VBSyntax.PropertyStatem
             return csIndentifierName;
         }
 
-        private static AccessorListSyntax ConvertSimpleAccessors(bool isWriteOnly, bool isReadonly, bool hasImplementation)
+        private static AccessorListSyntax ConvertSimpleAccessors(bool isWriteOnly, bool isReadonly, bool hasImplementation, Accessibility declaredAccessibility)
         {
             AccessorListSyntax accessors;
             var getAccessor = SyntaxFactory.AccessorDeclaration(Microsoft.CodeAnalysis.CSharp.SyntaxKind.GetAccessorDeclaration)
                 .WithSemicolonToken(SemicolonToken);
             var setAccessor = SyntaxFactory.AccessorDeclaration(Microsoft.CodeAnalysis.CSharp.SyntaxKind.SetAccessorDeclaration)
                 .WithSemicolonToken(SemicolonToken);
-            if (isWriteOnly)
+            if (isWriteOnly && declaredAccessibility != Accessibility.Private)
             {
                 getAccessor = getAccessor.AddModifiers(SyntaxFactory.Token(Microsoft.CodeAnalysis.CSharp.SyntaxKind.PrivateKeyword));
             }
 
-            if (isReadonly)
+            if (isReadonly && declaredAccessibility != Accessibility.Private)
             {
                 setAccessor = setAccessor.AddModifiers(SyntaxFactory.Token(Microsoft.CodeAnalysis.CSharp.SyntaxKind.PrivateKeyword));
             }

Tests/CSharp/ExpressionTests/ExpressionTests.cs

@@ -284,6 +284,7 @@ public static void Main()
 }
 1 target compilation errors:
 CS0825: The contextual keyword 'var' may only appear within a local variable declaration or in script code");
+            //BUG: Correct textual output, but requires var pattern syntax construct not available before CodeAnalysis 3
         }
 
         [Fact]

Tests/CSharp/MemberTests/PropertyMemberTests.cs

@@ -267,11 +267,9 @@ Private ReadOnly Property First As New List(Of String)
 
 internal partial class TestClass
 {
-    private List<string> First { get; private set; } = new List<string>();
+    private List<string> First { get; set; } = new List<string>();
     private int Second { get; set; } = 0;
-}
-1 target compilation errors:
-CS0273: The accessibility modifier of the 'TestClass.First.set' accessor must be more restrictive than the property or indexer 'TestClass.First'");
+}");
         }
 
         [Fact]