Omit conversion

GrahamTheCoder · GrahamTheCoder · commit 58eeadf128f8 · 2020-06-20T16:28:55.000+01:00
diff --git a/CodeConverter/CSharp/ExpressionNodeVisitor.cs b/CodeConverter/CSharp/ExpressionNodeVisitor.cs
@@ -730,6 +730,7 @@ public override async Task<CSharpSyntaxNode> VisitBinaryExpression(VBasic.Syntax
                         return visitBinaryExpression;
                     }
                     (lhs, rhs) = _visualBasicEqualityComparison.AdjustForVbStringComparison(node.Left, lhs, lhsTypeInfo, node.Right, rhs, rhsTypeInfo);
+                    omitConversion = true; // Already handled within for the appropriate types (rhs can become int in comparison)
                     break;
                 case VisualBasicEqualityComparison.RequiredType.Object:
                     return _visualBasicEqualityComparison.GetFullExpressionForVbObjectComparison(node, lhs, rhs);

Original file line number	Diff line number	Diff line change
`@@ -730,6 +730,7 @@ public override async Task<CSharpSyntaxNode> VisitBinaryExpression(VBasic.Syntax`
`730`	`730`	`return visitBinaryExpression;`
`731`	`731`	`}`
`732`	`732`	`(lhs, rhs) = _visualBasicEqualityComparison.AdjustForVbStringComparison(node.Left, lhs, lhsTypeInfo, node.Right, rhs, rhsTypeInfo);`
	`733`	`+ omitConversion = true; // Already handled within for the appropriate types (rhs can become int in comparison)`
`733`	`734`	`break;`
`734`	`735`	`case VisualBasicEqualityComparison.RequiredType.Object:`
`735`	`736`	`return _visualBasicEqualityComparison.GetFullExpressionForVbObjectComparison(node, lhs, rhs);`