Always use RefConversion.PreAssigment for methods

Timur Kelman · Timur Kelman · commit 41bda28ddd5c · 2024-07-24T10:58:03.000+02:00
diff --git a/CodeConverter/CSharp/ExpressionNodeVisitor.cs b/CodeConverter/CSharp/ExpressionNodeVisitor.cs
@@ -1891,6 +1891,8 @@ RefConversion GetRefConversion(VBSyntax.ExpressionSyntax expression)
             }
             else if (symbolInfo is IFieldSymbol { IsConst: true } or ILocalSymbol { IsConst: true }) {
                 return RefConversion.PreAssigment;
+            } else if (symbolInfo is IMethodSymbol) {
+                return RefConversion.PreAssigment;
             }
 
             if (DeclaredInUsing(symbolInfo)) return RefConversion.PreAssigment;

Original file line number	Diff line number	Diff line change
`@@ -1891,6 +1891,8 @@ RefConversion GetRefConversion(VBSyntax.ExpressionSyntax expression)`
`1891`	`1891`	`}`
`1892`	`1892`	`else if (symbolInfo is IFieldSymbol { IsConst: true } or ILocalSymbol { IsConst: true }) {`
`1893`	`1893`	`return RefConversion.PreAssigment;`
	`1894`	`+ } else if (symbolInfo is IMethodSymbol) {`
	`1895`	`+ return RefConversion.PreAssigment;`
`1894`	`1896`	`}`
`1895`	`1897`
`1896`	`1898`	`if (DeclaredInUsing(symbolInfo)) return RefConversion.PreAssigment;`