Skip to content

Commit 386d402

Browse files
Rename and add xml doc
1 parent ca624cb commit 386d402

2 files changed

Lines changed: 9 additions & 3 deletions

File tree

CodeConverter/CSharp/ByRefParameterVisitor.cs renamed to CodeConverter/CSharp/HoistedDeclarationStateVisitor.cs

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,20 @@
1212

1313
namespace ICSharpCode.CodeConverter.CSharp
1414
{
15-
public class ByRefParameterVisitor : VBasic.VisualBasicSyntaxVisitor<Task<SyntaxList<StatementSyntax>>>
15+
/// <summary>
16+
/// Allows adding a declaration to the surrounding scope (by sharing an instance of AdditionalLocals)
17+
/// e.g. Add a local variable declaration in the scope immediately before the expression currently being visited.
18+
/// e.g. Add a member declaration in the scope immediately before the member currently being visited.
19+
/// The current implementation uses a guid variable name, then replaces it later with a unique name by tracking the annotation added to it.
20+
/// </summary>
21+
public class HoistedDeclarationStateVisitor : VBasic.VisualBasicSyntaxVisitor<Task<SyntaxList<StatementSyntax>>>
1622
{
1723
private readonly VBasic.VisualBasicSyntaxVisitor<Task<SyntaxList<StatementSyntax>>> _wrappedVisitor;
1824
private readonly AdditionalLocals _additionalLocals;
1925
private readonly SemanticModel _semanticModel;
2026
private readonly HashSet<string> _generatedNames;
2127

22-
public ByRefParameterVisitor(VBasic.VisualBasicSyntaxVisitor<Task<SyntaxList<StatementSyntax>>> wrappedVisitor, AdditionalLocals additionalLocals,
28+
public HoistedDeclarationStateVisitor(VBasic.VisualBasicSyntaxVisitor<Task<SyntaxList<StatementSyntax>>> wrappedVisitor, AdditionalLocals additionalLocals,
2329
SemanticModel semanticModel, HashSet<string> generatedNames)
2430
{
2531
_wrappedVisitor = wrappedVisitor;

CodeConverter/CSharp/MethodBodyExecutableStatementVisitor.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ private MethodBodyExecutableStatementVisitor(VBasic.VisualBasicSyntaxNode method
6363
_withBlockLhs = withBlockLhs;
6464
_extraUsingDirectives = extraUsingDirectives;
6565
_methodsWithHandles = methodsWithHandles;
66-
var byRefParameterVisitor = new ByRefParameterVisitor(this, additionalLocals, semanticModel, _generatedNames);
66+
var byRefParameterVisitor = new HoistedDeclarationStateVisitor(this, additionalLocals, semanticModel, _generatedNames);
6767
CommentConvertingVisitor = new CommentConvertingMethodBodyVisitor(byRefParameterVisitor);
6868
_vbBooleanTypeSymbol = _semanticModel.Compilation.GetTypeByMetadataName("System.Boolean");
6969
_localsToInlineInLoop = localsToInlineInLoop;

0 commit comments

Comments
 (0)