Add ref keyword for Array.Resize

Author: GrahamTheCoder

CHANGELOG.md

@@ -9,7 +9,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 
 
 ### VB -> C#
-
+* When converting ReDim Preserve to Array.Resize, "ref" is now added
 
 ### C# -> VB
 

CodeConverter/CSharp/MethodBodyExecutableStatementVisitor.cs

@@ -229,7 +229,8 @@ private async Task<SyntaxList<StatementSyntax>> ConvertRedimClauseAsync(VBSyntax
             var csTargetArrayExpression = (ExpressionSyntax) await node.Expression.AcceptAsync(_expressionVisitor);
             var convertedBounds = (await CommonConversions.ConvertArrayBoundsAsync(node.ArrayBounds)).Sizes.ToList();
             if (preserve && convertedBounds.Count == 1) {
-                var arrayResize = SyntaxFactory.InvocationExpression(ValidSyntaxFactory.MemberAccess(nameof(Array), nameof(Array.Resize)), new[] { csTargetArrayExpression, convertedBounds.Single() }.CreateCsArgList());
+                var argumentList = new[] { csTargetArrayExpression, convertedBounds.Single() }.CreateCsArgList(SyntaxKind.RefKeyword);
+                var arrayResize = SyntaxFactory.InvocationExpression(ValidSyntaxFactory.MemberAccess(nameof(Array), nameof(Array.Resize)), argumentList);
                 return SingleStatement(arrayResize);
             }
             var newArrayAssignment = CreateNewArrayAssignment(node.Expression, csTargetArrayExpression, convertedBounds, node.SpanStart);

CodeConverter/Util/ExpressionSyntaxExtensions.cs

@@ -26,9 +26,13 @@ public static VBSyntax.ArgumentListSyntax CreateVbArgList<T>(this IEnumerable<T>
             return VBasic.SyntaxFactory.ArgumentList(VBasic.SyntaxFactory.SeparatedList(argExpressions.Select(e => (VBSyntax.ArgumentSyntax) VBasic.SyntaxFactory.SimpleArgument(e))));
         }
 
-        public static ArgumentListSyntax CreateCsArgList<T>(this IEnumerable<T> argExpressions) where T : ExpressionSyntax
+        public static ArgumentListSyntax CreateCsArgList<T>(this IEnumerable<T> argExpressions, params SyntaxKind[] refTokenKinds) where T : ExpressionSyntax
         {
-            return SyntaxFactory.ArgumentList(SyntaxFactory.SeparatedList(argExpressions.Select(SyntaxFactory.Argument)));
+            return SyntaxFactory.ArgumentList(SyntaxFactory.SeparatedList(argExpressions.Select((e, i) => {
+                var arg = SyntaxFactory.Argument(e);
+                if (i < refTokenKinds.Length) arg = arg.WithRefKindKeyword(SyntaxFactory.Token(refTokenKinds[i]));
+                return arg;
+            })));
         }
 
         /// <summary>

Tests/CSharp/MissingSemanticModelInfo/StatementTests.cs

@@ -43,7 +43,7 @@ public void Test()
         public async Task RedimOfUnknownVariableAsync()
         {
             await TestConversionVisualBasicToCSharpAsync(@"ReDim Preserve UnknownArray(unknownIntIdentifer)", @"{
-    Array.Resize(UnknownArray, unknownIntIdentifer + 1);
+    Array.Resize(ref UnknownArray, unknownIntIdentifer + 1);
 }
 
 2 source compilation errors:

Tests/CSharp/StatementTests/StatementTests.cs

@@ -483,8 +483,8 @@ public static int[] TestMethod(int[] numArray, int[] numArray2)
         numArray = new int[4];
         numArray = null;
         numArray2[1] = 1;
-        Array.Resize(numArray, 6);
-        Array.Resize(numArray2, 6);
+        Array.Resize(ref numArray, 6);
+        Array.Resize(ref numArray2, 6);
         var y = new int[7, 6];
         y[2, 3] = 1;
         var oldY = y;
@@ -494,9 +494,7 @@ public static int[] TestMethod(int[] numArray, int[] numArray2)
                 Array.Copy(oldY, i * oldY.GetLength(1), y, i * y.GetLength(1), Math.Min(oldY.GetLength(1), y.GetLength(1)));
         return numArray2;
     }
-}
-1 target compilation errors:
-CS1620: Argument 1 must be passed with the 'ref' keyword");
+}");
         }
 
         [Fact]