Skip to content

Commit 1856b78

Browse files
Update NuGet packages for Tests project (based on File/New xUnit project)
1 parent 21f3123 commit 1856b78

3 files changed

Lines changed: 13 additions & 12 deletions

File tree

Tests/CSharp/TriviaTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -424,7 +424,7 @@ End Sub
424424
var conversionResult = await ProjectConversion.ConvertTextAsync<VBToCSConversion>(vbCode, options);
425425

426426
var regex = new Regex(@"#error Cannot convert \w+ - see comment for details\s+ \/\* Cannot convert.*?\*\/", RegexOptions.Singleline);
427-
Assert.Equal(1, conversionResult.Exceptions.Count);
427+
Assert.Single(conversionResult.Exceptions);
428428
Assert.Matches(regex, conversionResult.ConvertedCode);
429429
}
430430
}

Tests/TestRunners/ConverterTestBase.cs

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ private static bool LineCanHaveCSharpComment(string l)
7474
.Skip(1).Select(afterPrefix => afterPrefix.Split('\n')[0].TrimEnd()).ToList();
7575
var missingSourceLineNumbers = lineNumbersAdded.Except(convertedCommentLineNumbers);
7676
if (missingSourceLineNumbers.Any()) {
77-
Assert.False(true, "Comments not converted from source lines: " + string.Join(", ", missingSourceLineNumbers) + GetSourceAndConverted(sourceWithComments, convertedCode));
77+
Assert.Fail("Comments not converted from source lines: " + string.Join(", ", missingSourceLineNumbers) + GetSourceAndConverted(sourceWithComments, convertedCode));
7878
}
7979
OurAssert.Equal(string.Join(", ", lineNumbersAdded), string.Join(", ", convertedCommentLineNumbers), () => GetSourceAndConverted(sourceWithComments, convertedCode));
8080
}
@@ -107,8 +107,7 @@ public async Task TestConversionVisualBasicToCSharpAsync(string visualBasicCode,
107107
bool incompatibleWithAutomatedCommentTesting = false)
108108
{
109109
if (expectSurroundingBlock) expectedCsharpCode = SurroundWithBlock(expectedCsharpCode);
110-
var conversionOptions = new TextConversionOptions(DefaultReferences.NetStandard2)
111-
{
110+
var conversionOptions = new TextConversionOptions(DefaultReferences.NetStandard2) {
112111
RootNamespaceOverride = _rootNamespace,
113112
ShowCompilationErrors = !expectSurroundingBlock
114113
};
@@ -163,8 +162,7 @@ private static void AssertConvertedCodeResultEquals(string convertedCodeFollowed
163162

164163
private static void AssertCodeEqual(string originalSource, string expectedConversion, string actualConversion)
165164
{
166-
OurAssert.EqualIgnoringNewlines(expectedConversion, actualConversion, () =>
167-
{
165+
OurAssert.EqualIgnoringNewlines(expectedConversion, actualConversion, () => {
168166
StringBuilder sb = OurAssert.DescribeStringDiff(expectedConversion, actualConversion);
169167
sb.AppendLine(OurAssert.LineSplitter);
170168
sb.AppendLine("source:");
@@ -182,8 +180,7 @@ private static (IReadOnlyCollection<string> Lines, IReadOnlyCollection<string> L
182180
{
183181
var lines = Utils.HomogenizeEol(code).Split(new[] { Environment.NewLine }, StringSplitOptions.None);
184182
var lineNumbersAdded = new List<string>();
185-
var newLines = lines.Select((line, i) =>
186-
{
183+
var newLines = lines.Select((line, i) => {
187184
var lineNumber = i.ToString();
188185
var potentialExistingComments = line.Split(new[] { singleLineCommentStart }, StringSplitOptions.None).Skip(1);
189186
if (potentialExistingComments.Count() == 1 || !lineCanHaveComment(line)) return line;
@@ -207,8 +204,7 @@ public CSToVBWithoutSimplifierConversion()
207204

208205
string ILanguageConversion.TargetLanguage => _baseConversion.TargetLanguage;
209206

210-
ConversionOptions ILanguageConversion.ConversionOptions
211-
{
207+
ConversionOptions ILanguageConversion.ConversionOptions {
212208
get => _baseConversion.ConversionOptions;
213209
set => _baseConversion.ConversionOptions = value;
214210
}

Tests/Tests.csproj

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,16 @@
1111
<ItemGroup>
1212
<PackageReference Include="Moq" Version="4.18.3" />
1313
<PackageReference Include="System.Collections.Immutable" Version="8.0.0" />
14-
<PackageReference Include="xunit" Version="2.4.2" />
15-
<PackageReference Include="xunit.runner.visualstudio" Version="2.4.5">
14+
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0" />
15+
<PackageReference Include="xunit" Version="2.6.6" />
16+
<PackageReference Include="xunit.runner.visualstudio" Version="2.5.6">
1617
<PrivateAssets>all</PrivateAssets>
1718
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
1819
</PackageReference>
20+
<PackageReference Include="coverlet.collector" Version="6.0.0">
21+
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
22+
<PrivateAssets>all</PrivateAssets>
23+
</PackageReference>
1924
</ItemGroup>
2025
<ItemGroup>
2126
<Service Include="{508349B6-6B84-4DF5-91F0-309BEEBAD82D}" />

0 commit comments

Comments
 (0)