recognize ref return properties when processing ByRef arguments

Timur Kelman · Timur Kelman · commit 0e79753d23c0 · 2024-07-19T12:06:04.000+02:00
diff --git a/CodeConverter/CSharp/ExpressionNodeVisitor.cs b/CodeConverter/CSharp/ExpressionNodeVisitor.cs
@@ -1833,7 +1833,9 @@ private RefConversion NeedsVariableForArgument(VBasic.Syntax.ArgumentSyntax node
         RefConversion GetRefConversion(VBSyntax.ExpressionSyntax expression)
         {
             var symbolInfo = GetSymbolInfoInDocument<ISymbol>(expression);
-            if (symbolInfo is IPropertySymbol propertySymbol) {
+            if (symbolInfo is IPropertySymbol propertySymbol
+            // a property in VB.NET code can be ReturnsByRef if it's defined in a C# assembly the VB.NET code references
+            && !propertySymbol.ReturnsByRef && !propertySymbol.ReturnsByRefReadonly) {
                 return propertySymbol.IsReadOnly ? RefConversion.PreAssigment : RefConversion.PreAndPostAssignment;
             }
 

Original file line number	Diff line number	Diff line change
`@@ -1833,7 +1833,9 @@ private RefConversion NeedsVariableForArgument(VBasic.Syntax.ArgumentSyntax node`
`1833`	`1833`	`RefConversion GetRefConversion(VBSyntax.ExpressionSyntax expression)`
`1834`	`1834`	`{`
`1835`	`1835`	`var symbolInfo = GetSymbolInfoInDocument<ISymbol>(expression);`
`1836`		`- if (symbolInfo is IPropertySymbol propertySymbol) {`
	`1836`	`+ if (symbolInfo is IPropertySymbol propertySymbol`
	`1837`	`+ // a property in VB.NET code can be ReturnsByRef if it's defined in a C# assembly the VB.NET code references`
	`1838`	`+ && !propertySymbol.ReturnsByRef && !propertySymbol.ReturnsByRefReadonly) {`
`1837`	`1839`	`return propertySymbol.IsReadOnly ? RefConversion.PreAssigment : RefConversion.PreAndPostAssignment;`
`1838`	`1840`	`}`
`1839`	`1841`