Found in whole-codebase review.
In esp32/src/pairing/PairingMode.cpp (~lines 55-62), the State::FAIL branch calls Board::onPairingFailed() every loop iteration with only delay(10).
- On ESP32 WROOM 32E,
Board::onPairingFailed() emits an NSG_LOG_ERROR line each call → the serial log is flooded at ~100 Hz forever (until manual reset).
- On M5Stack Core2 it just redraws when
shouldDraw() allows, so impact is smaller.
Requiring a manual reset after failure is fine (by design), but the log spam is not useful.
Proposal: print/draw the failure once when entering the FAIL state (e.g. track a failReported flag), and keep the loop idle afterwards.
Found in whole-codebase review.
In
esp32/src/pairing/PairingMode.cpp(~lines 55-62), theState::FAILbranch callsBoard::onPairingFailed()every loop iteration with onlydelay(10).Board::onPairingFailed()emits anNSG_LOG_ERRORline each call → the serial log is flooded at ~100 Hz forever (until manual reset).shouldDraw()allows, so impact is smaller.Requiring a manual reset after failure is fine (by design), but the log spam is not useful.
Proposal: print/draw the failure once when entering the FAIL state (e.g. track a
failReportedflag), and keep the loop idle afterwards.