Skip to content
This repository was archived by the owner on Aug 19, 2019. It is now read-only.
This repository was archived by the owner on Aug 19, 2019. It is now read-only.

Please make "targets" optional #71

Description

@eric-914

I've just discovered that these two options are incompatible with each other:

%msbuild% /t:Publish /p:DeployOnBuild=true
==> There is a circular dependency in the target dependency graph involving target "Publish"

This works:
%msbuild% /t:Publish

And this works:
%msbuild% /p:DeployOnBuild=true /p:PublishProfile=MyProfile.pubxml

Notice that the /target option isn't part of this. But msbuild-command-builder.js (line 11) requires a targets option, and will error if undefined.

I have found this as a workaround for the time being:
%msbuild% /t:Build /p:DeployOnBuild=true /p:PublishProfile=MyProfile.pubxml

The fix, I believe, is to change line 11 to:
if (options.targets) { args.push('/target:' + options.targets.join(';')); }

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions