From 43d164e1b7d42762ce0bc87e8755654d54aa7aae Mon Sep 17 00:00:00 2001
From: Stephanie Reinders <reinders.stephanie@gmail.com>
Date: Tue, 16 Dec 2025 17:02:19 -0600
Subject: [PATCH] fix: `phase_test()` now correctly ranks phases

---
 R/phase_test.R | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/R/phase_test.R b/R/phase_test.R
index cba808a..b9405c4 100644
--- a/R/phase_test.R
+++ b/R/phase_test.R
@@ -35,13 +35,14 @@ phase_test <- function(land1, land2, score, sigma_0 = NA, alpha = 0.05) {
     summarize(
       means = mean(score, na.rm = TRUE)
     ) %>% ungroup() %>%
+    arrange(means) %>%
     mutate(
-      ordered = (1:n)[order(.data$means)]
-    ) %>% arrange(means)
-  dframe <- dframe %>% mutate(
-    phase = avgs$ordered[.data$phase]
-  )
-
+      ordered = (1:n)
+    )
+  dframe <- dframe %>%
+    left_join(avgs %>% select(phase, ordered), by = "phase") %>%
+    mutate(phase = ordered) %>%  # overwrite phase with ordered
+    select(-ordered)
 
   est1 <- avgs$means[n]
   est2 <- avgs$means[floor(n/2)]