Skip to content

Commit db6b688

Browse files
committed
Finess the frontend address configurations
1 parent 4a59ea6 commit db6b688

4 files changed

Lines changed: 22 additions & 7 deletions

File tree

.env.example

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,10 @@ PORT=<Some Port such as 3000>
33
#The address on which the server is being run:
44
ADDRESS=<Some address such as 127.0.0.1>
55

6+
#front-end server
7+
FRONTEND_ADDRESS_DEV=localhost:1337
8+
FRONTEND_ADDRESS_DEPLOY=app.mchacks.ca
9+
610
#The info for the deployment database
711
DB_ADDRESS_DEPLOY=<Deployment address>
812
DB_USER_DEPLOY=<username for db connection>

app.js

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,16 @@ Services.db.connect(app);
3535
let corsOptions = {};
3636

3737
if (!Services.env.isProduction()) {
38-
corsOptions = { origin: ["http://localhost:1337", "http://localhost:8989"], credentials: true };
38+
corsOptions = {
39+
origin: [process.env.FRONTEND_ADDRESS_DEV],
40+
credentials: true
41+
};
3942
} else {
4043
// TODO: change this when necessary
41-
corsOptions = { origin: ["https://mchacks.ca/"], credentials: true };
44+
corsOptions = {
45+
origin: [process.env.FRONTEND_ADDRESS_DEPLOY],
46+
credentials: true
47+
};
4248
}
4349

4450
app.use(cors(corsOptions));

middlewares/account.middleware.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@ const Services = {
77
Logger: require("../services/logger.service"),
88
Account: require("../services/account.service"),
99
AccountConfirmation: require("../services/accountConfirmation.service"),
10-
Email: require("../services/email.service")
10+
Email: require("../services/email.service"),
11+
Env: require("../services/env.service")
1112
};
1213

1314
const Middleware = {
@@ -149,8 +150,9 @@ async function inviteAccount(req, res, next) {
149150
const accountType = req.body.accountType;
150151
const confirmationObj = await Services.AccountConfirmation.create(accountType, email);
151152
const confirmationToken = Services.AccountConfirmation.generateToken(confirmationObj.id);
153+
const address = Services.Env.isProduction() ? process.env.FRONTEND_ADDRESS_DEPLOY : process.env.FRONTEND_ADDRESS_DEV;
152154

153-
const mailData = Services.AccountConfirmation.generateAccountInvitationEmail(process.env.FRONTEND_ADDRESS, email, accountType, confirmationToken);
155+
const mailData = Services.AccountConfirmation.generateAccountInvitationEmail(address, email, accountType, confirmationToken);
154156
if (mailData !== undefined) {
155157
Services.Email.send(mailData, (err) => {
156158
if (err) {

middlewares/auth.middleware.js

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,8 @@ async function sendResetPasswordEmailMiddleware(req, res, next) {
140140
const ResetPasswordTokenModel = await Services.ResetPasswordToken.findByAccountId(user.id);
141141
//generate email
142142
const token = Services.ResetPasswordToken.generateToken(ResetPasswordTokenModel.id, user.id);
143-
const mailData = Services.ResetPasswordToken.generateResetPasswordEmail(process.env.FRONTEND_ADDRESS, req.body.email, token);
143+
const address = Services.Env.isProduction() ? process.env.FRONTEND_ADDRESS_DEPLOY : process.env.FRONTEND_ADDRESS_DEV;
144+
const mailData = Services.ResetPasswordToken.generateResetPasswordEmail(address, req.body.email, token);
144145
if (mailData !== undefined) {
145146
Services.Email.send(mailData, (err) => {
146147
if (err) {
@@ -176,7 +177,8 @@ async function sendConfirmAccountEmailMiddleware(req, res, next) {
176177
await Services.AccountConfirmation.create(Constants.General.HACKER, account.email, account.id);
177178
const accountConfirmationToken = await Services.AccountConfirmation.findByAccountId(account.id);
178179
const token = Services.AccountConfirmation.generateToken(accountConfirmationToken.id, account.id);
179-
const mailData = Services.AccountConfirmation.generateAccountConfirmationEmail(process.env.FRONTEND_ADDRESS, account.email, Constants.General.HACKER, token);
180+
const address = Services.Env.isProduction() ? process.env.FRONTEND_ADDRESS_DEPLOY : process.env.FRONTEND_ADDRESS_DEV;
181+
const mailData = Services.AccountConfirmation.generateAccountConfirmationEmail(address, account.email, Constants.General.HACKER, token);
180182
if (mailData !== undefined) {
181183
Services.Email.send(mailData, (err) => {
182184
if (err) {
@@ -214,7 +216,8 @@ async function resendConfirmAccountEmail(req, res, next) {
214216
});
215217
}
216218
const token = Services.AccountConfirmation.generateToken(accountConfirmationToken.id, account.id);
217-
const mailData = Services.AccountConfirmation.generateAccountConfirmationEmail(process.env.FRONTEND_ADDRESS, account.email, accountConfirmationToken.accountType, token);
219+
const address = Services.Env.isProduction() ? process.env.FRONTEND_ADDRESS_DEPLOY : process.env.FRONTEND_ADDRESS_DEV;
220+
const mailData = Services.AccountConfirmation.generateAccountConfirmationEmail(address, account.email, accountConfirmationToken.accountType, token);
218221
if (mailData !== undefined) {
219222
Services.Email.send(mailData, (err) => {
220223
if (err) {

0 commit comments

Comments
 (0)