feat: fix non-determinism of npm run seed (Bugfix/651) (#652)

* fix: hasOwnProperty vulnerability (see https://eslint.org/docs/rules/no-prototype-builtins)
* feat: _id value to all route objects, starting at 100 and moving upwards. Add warning at top of file to maintain naming standard.
* feat: update role.constant.js to use the new _id attribute so that ids are deterministic between two runs of npm run seed.
* feat: update architecture documentation

Author: pierreTklein

constants/role.constant.js

@@ -151,27 +151,26 @@ function createAllSingularRoles() {
     const allRoutes = Constants.Routes.allRoutes;
     let roles = [];
 
-    // i is unique integer so that objectId is constant
-    var i = 1000000;
     for (let routeGroupKey in allRoutes) {
-        if (!allRoutes.hasOwnProperty(routeGroupKey)) {
+        if (!Object.prototype.hasOwnProperty.call(allRoutes, routeGroupKey)) {
             continue;
         }
 
         const routeGroup = allRoutes[routeGroupKey];
         for (let routeKey in routeGroup) {
-            if (!routeGroup.hasOwnProperty(routeKey)) {
+            // Iterating through the attributes in the routeGroup object
+            if (!Object.prototype.hasOwnProperty.call(routeGroup, routeKey)) {
+                // Avoid all prototype attributes
                 continue;
             }
 
             let role = {
-                _id: mongoose.Types.ObjectId(i),
+                _id: routeGroup[routeKey]._id,
                 name: routeKey + routeGroupKey,
                 routes: routeGroup[routeKey]
             };
             let roleName = role.name;
             roles[roleName] = role;
-            i -= 1;
         }
     }
 
@@ -197,7 +196,7 @@ function createAllRoles() {
 
     const singularRoles = createAllSingularRoles();
     for (let role in singularRoles) {
-        if (!singularRoles.hasOwnProperty(role)) {
+        if (!Object.prototype.hasOwnProperty.call(singularRoles, role)) {
             continue;
         }
         allRolesObject[role] = singularRoles[role];