Merge branch 'develop' into refactor/199-cleanDocumentation

Author: pierreTklein

middlewares/hacker.middleware.js

@@ -243,6 +243,26 @@ async function sendStatusUpdateEmail(req, res, next) {
         Services.Email.sendStatusUpdate(account.firstName, account.email, req.body.status, next);
     }
 }
+
+/**
+ * Sends an email telling the user that they have applied. This is used exclusively when we POST a hacker.
+ * @param {{body: {hacker: {accountId: string}}}} req 
+ * @param {*} res 
+ * @param {(err?:*)=>void} next 
+ */
+async function sendAppliedStatusEmail(req, res, next) {
+    const hacker = req.body.hacker;
+    const account = await Services.Account.findById(hacker.accountId);
+    if (!account) {
+        return next({
+            status: 500,
+            message: Constants.Error.GENERIC_500_MESSAGE,
+            error: {}
+        });
+    }
+    Services.Email.sendStatusUpdate(account.firstName, account.email, Constants.General.HACKER_STATUS_APPLIED, next);
+}
+
 /**
  * If the current hacker's status is Constants.HACKER_STATUS_NONE, and the hacker's application is completed,
  * then it will change the status of the hacker to Constants.General.HACKER_STATUS_APPLIED, and then email the hacker to 
@@ -450,6 +470,7 @@ module.exports = {
     uploadResume: Middleware.Util.asyncMiddleware(uploadResume),
     downloadResume: Middleware.Util.asyncMiddleware(downloadResume),
     sendStatusUpdateEmail: Middleware.Util.asyncMiddleware(sendStatusUpdateEmail),
+    sendAppliedStatusEmail: Middleware.Util.asyncMiddleware(sendAppliedStatusEmail),
     updateHacker: Middleware.Util.asyncMiddleware(updateHacker),
     validateConfirmedStatus: Middleware.Util.asyncMiddleware(validateConfirmedStatus),
     checkDuplicateAccountLinks: Middleware.Util.asyncMiddleware(checkDuplicateAccountLinks),

middlewares/validators/validator.helper.js

@@ -328,7 +328,6 @@ function applicationValidator(fieldLocation, fieldname, optional = true) {
 
     //helper object to iterate through the items in the application and track which items are not valid.
     const hasValid = {
-        resume: false,
         github: false,
         dropler: false,
         personal: false,
@@ -345,7 +344,6 @@ function applicationValidator(fieldLocation, fieldname, optional = true) {
             checkFalsy: true
         }).custom(app => {
             const jobInterests = Constants.JOB_INTERESTS;
-            hasValid.resume = (!app.portfolioURL.resume || typeof (app.portfolioURL.resume) === "string");
             hasValid.github = (!app.portfolioURL.github || typeof (app.portfolioURL.github) === "string");
             hasValid.dropler = (!app.portfolioURL.dropler || typeof (app.portfolioURL.dropler) === "string");
             hasValid.personal = (!app.portfolioURL.personal || typeof (app.portfolioURL.personal) === "string");
@@ -365,7 +363,6 @@ function applicationValidator(fieldLocation, fieldname, optional = true) {
     } else {
         return application.custom(app => {
             const jobInterests = Constants.JOB_INTERESTS;
-            hasValid.resume = (typeof (app.portfolioURL.resume) === "string");
             hasValid.github = (!app.portfolioURL.github || typeof (app.portfolioURL.github) === "string");
             hasValid.dropler = (!app.portfolioURL.dropler || typeof (app.portfolioURL.dropler) === "string");
             hasValid.personal = (!app.portfolioURL.personal || typeof (app.portfolioURL.personal) === "string");
@@ -441,7 +438,7 @@ function jwtValidator(fieldLocation, fieldname, jwtSecret, optional = true) {
  * @param {"query" | "body" | "header" | "param"} fieldLocation the location where the field should be found
  * @param {string} fieldname name of the field that needs to be validated.
  */
-function searchModelValidator(fieldLocation, fieldName){
+function searchModelValidator(fieldLocation, fieldName) {
     const paramChain = setProperValidationChainBuilder(fieldLocation, fieldName, "Must be a valid searchable model");
     return paramChain.exists().withMessage("Model must be provided")
         .isLowercase().withMessage("Model must be lower case")
@@ -456,9 +453,11 @@ function searchModelValidator(fieldLocation, fieldName){
  */
 function searchValidator(fieldLocation, fieldname) {
     const search = setProperValidationChainBuilder(fieldLocation, fieldname, "Invalid search query");
-    
+
     return search.exists().withMessage("Search query must be provided")
-        .custom((value, {req}) => {
+        .custom((value, {
+            req
+        }) => {
             //value is a serialized JSON
             value = JSON.parse(value);
             let modelString = req.params.model
@@ -506,7 +505,9 @@ function searchSortValidator(fieldLocation, fieldName) {
     return searchSort.optional({
             checkFalsy: true
         })
-        .custom((value, {req}) => {
+        .custom((value, {
+            req
+        }) => {
             let modelString = req.params.model
             if (modelString.equals("hacker")) {
                 model = Models.Hacker;

models/hacker.model.js

@@ -34,6 +34,7 @@ const HackerSchema = new mongoose.Schema({
             //gcloud bucket link
             resume: {
                 type: String,
+                default: ""
             },
             github: {
                 type: String
@@ -118,10 +119,9 @@ HackerSchema.methods.isApplicationComplete = function () {
  */
 HackerSchema.statics.searchableField = function (field) {
     const schemaField = HackerSchema.path(field)
-    if(schemaField != undefined){
+    if (schemaField != undefined) {
         return schemaField.instance
-    }
-    else{
+    } else {
         return null;
     }
 };

routes/api/hacker.js

@@ -163,6 +163,7 @@ module.exports = {
             Middleware.Hacker.addDefaultStatus,
             Middleware.Auth.createRoleBindings(CONSTANTS.HACKER),
             Middleware.Hacker.createHacker,
+            Middleware.Hacker.sendAppliedStatusEmail,
             Controllers.Hacker.createdHacker
         );
         /**